Skip Menu |

This queue is for tickets about the Test-NoBreakpoints CPAN distribution.

Report information
The Basics
Id: 53609
Status: resolved
Worked: 1.8 hours (105 min)
Priority: 0/
Queue: Test-NoBreakpoints

People
Owner: JFITZ [...] cpan.org
Requestors: APOCAL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.13
Fixed in: (no value)



Subject: The module doesn't pass the testsuite
Hello, First of all, thanks for such a great module! I'm trying to use it now and is unable to get the module to pass the testsuite. I found out that the major culprit is the "depth" parameter to Test::Tester. Here's a patch that fixes your testsuite so everything passes :) Here's a sample output from "make test": t/05_no_breakpoints_ok.t ............ 1/47 # Looks like you planned 47 tests but ran 55. t/05_no_breakpoints_ok.t ............ Dubious, test returned 255 (wstat 65280, 0xff00) All 47 subtests passed t/06_all_files_no_breakpoints_ok.t .. 1/28 # Failed test 'checking depth' # at t/06_all_files_no_breakpoints_ok.t line 23. # got: '2' # expected: '1' # You need to change $Test::Builder::Level # Failed test 'checking depth' # at t/06_all_files_no_breakpoints_ok.t line 23. # got: '2' # expected: '1' # You need to change $Test::Builder::Level -- ~Apocalypse
Subject: nobreakpoints.diff
diff -urbd Test-NoBreakpoints-0.13/t/05_no_breakpoints_ok.t Test-NoBreakpoints-0.13_local/t/05_no_breakpoints_ok.t --- t/05_no_breakpoints_ok.t 2005-01-13 11:01:57.000000000 -0700 +++ t/05_no_breakpoints_ok.t 2010-01-11 15:18:18.000000000 -0700 @@ -5,7 +5,7 @@ BEGIN { use Test::Tester 0.09; use Test::More; - our $tests = 46; + our $tests = 54; eval "use Test::NoWarnings"; $tests++ unless( $@ ); plan tests => $tests; diff -urbd Test-NoBreakpoints-0.13/t/06_all_files_no_breakpoints_ok.t Test-NoBreakpoints-0.13_local/t/06_all_files_no_breakpoints_ok.t --- t/06_all_files_no_breakpoints_ok.t 2005-01-13 11:01:57.000000000 -0700 +++ t/06_all_files_no_breakpoints_ok.t 2010-01-11 15:19:37.000000000 -0700 @@ -5,7 +5,7 @@ BEGIN { use Test::Tester 0.09; use Test::More; - our $tests = 27; + our $tests = 37; eval "use Test::NoWarnings"; $tests++ unless( $@ ); plan tests => $tests; @@ -21,46 +21,56 @@ [ { ok => 1, + depth => 2, name => 'no breakpoint test of ./01_use.t', }, { ok => 1, + depth => 2, name => 'no breakpoint test of ./02_pod.t', }, { ok => 1, + depth => 2, name => 'no breakpoint test of ./04_all_perl_files.t', }, { ok => 0, + depth => 2, name => 'no breakpoint test of ./05_no_breakpoints_ok.t', diag => 'breakpoint found in ./05_no_breakpoints_ok.t: $DB::signal =1' . "\n", }, { ok => 0, + depth => 2, name => 'no breakpoint test of ./06_all_files_no_breakpoints_ok.t', diag => 'breakpoint found in ./06_all_files_no_breakpoints_ok.t: $DB::signal =1' . "\n", }, { ok => 1, + depth => 2, name => 'no breakpoint test of ./07_deprecated_warnings.t', }, { ok => 1, + depth => 2, name => 'no breakpoint test of ./08_deprecated.t', }, { ok => 0, + depth => 2, name => 'no breakpoint test of ./baz/foo.t', diag => 'breakpoint found in ./baz/foo.t: $DB::signal = 1' . "\n", }, { ok => 0, + depth => 2, name => 'no breakpoint test of ./baz/gzonk/foo.pl', diag => 'breakpoint found in ./baz/gzonk/foo.pl: $DB::single = 2' . "\n", }, { ok => 1, + depth => 2, name => 'no breakpoint test of ./baz/quux/Foo.pm', }, ], diff -urbd Test-NoBreakpoints-0.13/t/08_deprecated.t Test-NoBreakpoints-0.13_local/t/08_deprecated.t --- t/08_deprecated.t 2005-01-13 11:01:57.000000000 -0700 +++ t/08_deprecated.t 2010-01-11 15:19:54.000000000 -0700 @@ -11,7 +11,7 @@ BEGIN { use Test::Tester 0.09; use Test::More; - our $tests = 17; + our $tests = 21; eval "use Test::NoWarnings"; $tests++ unless( $@ ); plan tests => $tests; @@ -39,14 +39,17 @@ [ { ok => 1, + depth => 2, name => 'no breakpoint test of ./01_use.t', }, { ok => 1, + depth => 2, name => 'no breakpoint test of ./02_pod.t', }, { ok => 1, + depth => 2, name => 'no breakpoint test of ./04_all_perl_files.t', }, ],
Is this module AbandonWare now? I'd quite like to use it ... if it's been abandoned I don't mind taking over maintenance duties - I just don't know how to do so, or even if it's required.
On Tue Jan 03 16:43:50 2012, CHISEL wrote: Show quoted text
> Is this module AbandonWare now? > > I'd quite like to use it ... if it's been abandoned I don't mind taking > over maintenance duties - I just don't know how to do so, or even if > it's required.
I've naughtily added this to my own VCS and applied the patch and done sme work to make it easier [for me] to bundle and release: https://github.com/chiselwright/test-nobreakpoints
RT-Send-CC: james+perl [...] nadt.net
On Tue Jan 03 17:21:42 2012, CHISEL wrote: Show quoted text
> On Tue Jan 03 16:43:50 2012, CHISEL wrote:
> > Is this module AbandonWare now?
I've done a little more clean-up work tonight; I'm just not sure how to get the author's attention. I suspect they're not getting any email alerts for this distro.
Fixed in v0.14, pre-release available at https://github.com/jf647/Test-NoBreakpoints/tree/chizel_v014
Fixed and uploaded as v0.14. Thanks to Chizel for the heavy lifting on this fix.