Skip Menu |

This queue is for tickets about the Catalyst-Plugin-PageCache CPAN distribution.

Report information
The Basics
Id: 53529
Status: resolved
Priority: 0/
Queue: Catalyst-Plugin-PageCache

People
Owner: Nobody in particular
Requestors: rod.taylor [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.22
Fixed in: (no value)



Subject: keymaker call style change
The call to use a provided keymaker seems to fail as the current "$keymaker->($c)" style. Cache_hook calls are in a style more like "$c->$keymaker()" which seems to work fine for a function provided at configuration time. Small patch attached.
Subject: keymaker.patch
*** Catalyst-Plugin-PageCache_HOOKS/lib/Catalyst/Plugin/PageCache.pm 2010-01-08 18:13:24.000000000 -0500 --- Catalyst-Plugin-PageCache_KEYNAME/lib/Catalyst/Plugin/PageCache.pm 2010-01-08 19:15:35.000000000 -0500 *************** *** 444,450 **** # override key if required my $keymaker = $c->config->{'Plugin::PageCache'}->{key_maker}; ! my $key = $keymaker ? $keymaker->($c) : "/" . $c->req->path; # prepend language if I18N present. if ( $c->can('language') ) { --- 444,450 ---- # override key if required my $keymaker = $c->config->{'Plugin::PageCache'}->{key_maker}; ! my $key = $keymaker ? $c->$keymaker() : "/" . $c->req->path; # prepend language if I18N present. if ( $c->can('language') ) {
Applied, with a minor doc addition. Thanks!