Bug #53467 for Tk: Support for mingw-w64 gcc compiler (MS Windows)

Thu Jan 07 03:19:24 2010 kmx [...] cpan.org - Ticket created

Subject:

Support for mingw-w64 gcc compiler (MS Windows)

Hi

I would like to propose the following simple patch that is needed for building with mingw-w64.sf.net gcc compiler (technically it is a competitor to gcc compiler from mingw.org project - the main advantage is that mingw-w64 delivers both 32/64-bit compilers).

The patch is related to tkWinX.c

- #ifndef _WIN32_IE
+ #if !defined( _WIN32_IE) && !defined(__MINGW64_VERSION_MAJOR)
#define _WIN32_IE 0x0300
#endif

The reason for this patch is that value of _WIN32_IE is properly defined in commctrl.h and the value set in tkWinX.c is in collision with one in commctrl.h which in the end leads to the following error:

..../include/commctrl.h:14:2: error: #error _WIN32_IE setting conflicts

--
kmx

Thu Jan 07 03:21:14 2010 kmx [...] cpan.org - Status changed from 'new' to 'open'

Fri Jan 22 15:47:52 2010 SREZIC [...] cpan.org - Correspondence added

On Thu Jan 07 03:19:24 2010, KMX wrote: Show quoted text

> Hi > > I would like to propose the following simple patch that is needed for > building > with mingw-w64.sf.net gcc compiler (technically it is a competitor to > gcc > compiler from mingw.org project - the main advantage is that mingw-w64 > delivers > both 32/64-bit compilers). > > The patch is related to tkWinX.c > > - #ifndef _WIN32_IE > + #if !defined( _WIN32_IE) && !defined(__MINGW64_VERSION_MAJOR) > #define _WIN32_IE 0x0300 > #endif > > The reason for this patch is that value of _WIN32_IE is properly > defined in > commctrl.h and the value set in tkWinX.c is in collision with one in > commctrl.h > which in the end leads to the following error: > > ..../include/commctrl.h:14:2: error: #error _WIN32_IE setting > conflicts >

Thanks, it is patched in the svn repo (https://svn.perl.org/modules/Tk/trunk @ 13766) Can you try if it works now correctly? Regards, Slaven

Fri Jan 22 15:47:53 2010 SREZIC [...] cpan.org - Status changed from 'open' to 'patched'

Wed Jan 27 15:24:03 2010 kmx [...] cpan.org - Correspondence added

Show quoted text

> Can you try if it works now correctly?

Revision 13772 is OK - with 32bit compiler by mingw-w64.sf.net project (still some issues on 64bit)

Is there any chance to see at least a Tk dev version with this fix on CPAN?

Thanks.

--
kmx

Wed Jan 27 15:24:04 2010 The RT System itself - Status changed from 'patched' to 'open'

Tue Feb 02 05:41:59 2010 kmx [...] cpan.org - Correspondence added

Show quoted text

> Is there any chance to see at least a Tk dev version with this fix on
> CPAN?

Thanks for Tk-804.028_502

--
kmx

Tue Feb 02 05:42:04 2010 kmx [...] cpan.org - Status changed from 'open' to 'patched'

Tue Feb 02 06:59:59 2010 SREZIC [...] cpan.org - Status changed from 'patched' to 'resolved'

Tue Feb 02 06:59:59 2010 SREZIC [...] cpan.org - Fixed in 804.028_502 added