Bug #53424 for HTTP-Body: failed test in t/05urlencoded.t

I do not want to judge on the YAML release but introducing a policy towards Unicode encodings seems like a good thing on their side. Unfortunately it leaves YAML::LoadFile poisoned. On the other hand, HTTP::Body::UrlEncoded doesn't have a policy towards encoding but probably should have. The fix I would suggest for HTTP::Body is to refuse using YAML::LoadFile and use the unpoisoned YAML::Load instead. So my immediate fix would be this patch: --- t/05urlencoded.t~ 2010-01-09 11:16:34.000000000 +0100 +++ t/05urlencoded.t 2010-01-09 11:20:24.000000000 +0100 @@ -14,11 +14,15 @@ my $path = catdir( getcwd(), 't', 'data', 'urlencoded' ); +sub slurp ($) { + return scalar do { open my $fh, shift or die; local $/; <$fh> }; +} + for ( my $i = 1; $i <= 6; $i++ ) { my $test = sprintf( "%.3d", $i ); - my $headers = YAML::LoadFile( catfile( $path, "$test-headers.yml" ) ); - my $results = YAML::LoadFile( catfile( $path, "$test-results.yml" ) ); + my $headers = YAML::Load( slurp catfile( $path, "$test-headers.yml" ) ); + my $results = YAML::Load( slurp catfile( $path, "$test-results.yml" ) ); my $content = IO::File->new( catfile( $path, "$test-content.dat" ) ); my $body = HTTP::Body->new( $headers->{'Content-Type'}, $headers->{'Content-Length'} ); All tests pass again with this. HTH,

Hi: I have no idea if this is actually fixed, however, it seems that the module now uses PAML (it includes this, and it's not released on CPAN) to serialize data structures (using something like Data::Dumper) into .pml files, then load them using eval... I've removed the patch in the Debian version of this package, but I'm not sure whether this really fixes the issue we've all been having. Cheers, Jonathan