Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Module-Starter CPAN distribution.

Report information
The Basics
Id: 53339
Status: resolved
Priority: 0/
Queue: Module-Starter
People
Owner: Nobody in particular
Requestors: bdfoy [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Jan 04 08:11:36 2010 bdfoy [...] cpan.org - Ticket created
Subject: Module::Starter::Simple should not build the MANIFEST itself
 Since Module::Starter::Simple tries to build the MANIFEST itself, it corrupts MANIFEST when a plugin uses it. It should call the manifest target in the build system to create it correctly. This ensures that it respects MANIFEST.SKIP or any special subclass logic.
  Tue Jan 05 10:15:53 2010 XSAWYERX [...] cpan.org - Status changed from 'new' to 'open'
  Tue Jan 05 10:25:19 2010 XSAWYERX [...] cpan.org - Correspondence added
Hi Brian.

I spoke to Andy about this and we consulted with Ricardo.

We've decided to remove the creation of the MANIFEST file and opt for creating a generic MANIFEST.SKIP.

Either way, I don't see how your suggestion would fix it. Module::Starter::Simple is only a generic plugin. It shouldn't call other plugins' methods, but rather rely on itself.
Any module (or plugin) that uses Module::Starter::Simple can override the MANIFEST_guts or create_MANIFEST file.

  Tue Jan 05 11:33:51 2010 bdfoy [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #53339] Module::Starter::Simple should not build the MANIFEST itself
Date: Tue, 5 Jan 2010 17:33:14 +0100
To: bug-Module-Starter [...] rt.cpan.org
From: brian d foy <bdfoy [...] cpan.org>
On Tue, Jan 5, 2010 at 4:25 PM, Sawyer X via RT <bug-Module-Starter@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=53339 >
Show quoted text
> Either way, I don't see how your suggestion would fix it. > Module::Starter::Simple is only a generic plugin. It shouldn't call other > plugins' methods, but rather rely on itself.
I wasn't suggesting that it call other module's plugins. Even without any other plugins, Module::Starter shouldn't try to make the MANIFEST on it's own using its own logic. If someone doesn't override create_MANIFEST but supplies different templates, such as a Build.PL that subclasses ACTION_manifest, Module::Starter will do the wrong thing. No one has to override it if Module::Starter::Simple does it correctly. :) -- brian d foy <brian.d.foy@gmail.com> http://www.pair.com/~comdog/
  Sun May 22 11:19:07 2011 XSAWYERX [...] cpan.org - Status changed from 'open' to 'resolved'