Bug #53101 for Catalyst-Model-DBIC-Schema: test 05testapp.t exits with non-zero code if disabled

Fri Dec 25 14:24:53 2009 zwon [...] trinitum.org - Ticket created

Subject:

test 05testapp.t exits with non-zero code if disabled

Test suite fails on t/05testapp.t unless C_M_DBIC_SCHEMA_TESTAPP is set: $ prove -Iblib t/05testapp.t t/05testapp.t .. invalid top directory at /usr/share/perl/5.10/File/Find.pm line 598. END failed--call queue aborted at t/05testapp.t line 658. t/05testapp.t .. skipped: Enable this optional test with $ENV{C_M_DBIC_SCHEMA_TESTAPP} Test Summary Report ------------------- t/05testapp.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Files=1, Tests=0, 0 wallclock secs ( 0.01 usr 0.02 sys + 0.04 cusr 0.01 csys = 0.08 CPU) Result: FAIL If I set C_M_DBIC_SCHEMA_TESTAPP environment variable test passes. -- Pavel Shaydo

Fri Dec 25 14:41:39 2009 zwon [...] trinitum.org - Correspondence added

From:

zwon [...] trinitum.org

The patch disables END block if test was skipped -- Pavel Shaydo

--- t/05testapp.t 2009-12-25 22:32:38.394838308 +0300 +++ t/05testapp.t 2009-12-25 22:36:39.462178225 +0300 @@ -83,6 +83,8 @@ } END { - chdir($test_dir); - finddepth(\&rm_rf, $cat_dir); + if ( $ENV{C_M_DBIC_SCHEMA_TESTAPP} ) { + chdir($test_dir); + finddepth( \&rm_rf, $cat_dir ); + } }

Sat Dec 26 08:11:07 2009 rkitover [...] cpan.org - Correspondence added

Fixed in 0.33, thank you for the report and the patch!

Sat Dec 26 08:11:10 2009 The RT System itself - Status changed from 'new' to 'open'

Sat Dec 26 08:11:10 2009 rkitover [...] cpan.org - Status changed from 'open' to 'resolved'