Bug #52969 for Catalyst-Plugin-RequireSSL: Many warnings during "make test"

I was starting to look into the "" warning. I downloaded 0.06 and ran "make test" to receive the following: chisel@cwright-desktop:Catalyst-Plugin-RequireSSL-0.06$ make test /opt/xt/arch-64/xt-perl/bin/perl Build --makefile_env_macros 1 test Copying lib/Catalyst/Plugin/RequireSSL.pm -> blib/lib/Catalyst/Plugin/RequireSSL.pm t/01use.t ............ ok t/02pod.t ............ skipped: set TEST_POD to enable this test t/03podcoverage.t .... skipped: set TEST_POD to enable this test t/04ssl.t ............ TestApp::C::SSL is using the deprecated Catalyst::Base, update your application as this will be removed in the next major release at /opt/xt/xt-perl/lib/site_perl/5.8.8/Catalyst/Base.pm line 7. [warn] Your application is using the deprecated ::[MVC]:: type naming scheme. Please switch your class names to ::Model::, ::View:: and ::Controller: as appropriate. [warn] Action methods (default) found defined in your application class, TestApp. This is deprecated, please move them into a Root controller. t/04ssl.t ............ ok t/05ssl_host.t ....... TestApp::C::SSL is using the deprecated Catalyst::Base, update your application as this will be removed in the next major release at /opt/xt/xt-perl/lib/site_perl/5.8.8/Catalyst/Base.pm line 7. [warn] Your application is using the deprecated ::[MVC]:: type naming scheme. Please switch your class names to ::Model::, ::View:: and ::Controller: as appropriate. [warn] Action methods (default) found defined in your application class, TestApp. This is deprecated, please move them into a Root controller. t/05ssl_host.t ....... ok t/06remain_in_ssl.t .. TestApp::C::SSL is using the deprecated Catalyst::Base, update your application as this will be removed in the next major release at /opt/xt/xt-perl/lib/site_perl/5.8.8/Catalyst/Base.pm line 7. [warn] Your application is using the deprecated ::[MVC]:: type naming scheme. Please switch your class names to ::Model::, ::View:: and ::Controller: as appropriate. [warn] Action methods (default) found defined in your application class, TestApp. This is deprecated, please move them into a Root controller. t/06remain_in_ssl.t .. ok All tests successful. Files=6, Tests=28, 2 wallclock secs ( 0.02 usr 0.01 sys + 2.04 cusr 0.17 csys = 2.24 CPU) Result: PASS chisel@cwright-desktop:Catalyst-Plugin-RequireSSL-0.06$ ls I took a few minutes to clean it up a little - I don't know which SCM you use so I've attached a tarball containing my changes. (still as 0.06) I've also attached a patch (diff -Naur Catalyst-Plugin-RequireSSL-0.06 Catalyst-Plugin-RequireSSL-0.06.new) This doesn't resolve my initial issue with https://rt.cpan.org/Ticket/Display.html?id=48328

diff -Naur Catalyst-Plugin-RequireSSL-0.06/Makefile.PL Catalyst-Plugin-RequireSSL-0.06.new/Makefile.PL --- Catalyst-Plugin-RequireSSL-0.06/Makefile.PL 2007-03-06 15:45:35.000000000 +0000 +++ Catalyst-Plugin-RequireSSL-0.06.new/Makefile.PL 2009-12-22 11:56:43.949301532 +0000 @@ -1,4 +1,4 @@ -# Note: this file was auto-generated by Module::Build::Compat version 0.03 +# Note: this file was auto-generated by Module::Build::Compat version 0.35 unless (eval "use Module::Build::Compat 0.02; 1" ) { print "This module requires Module::Build to install itself.\n"; @@ -27,5 +27,8 @@ eval "use Module::Build::Compat 0.02; 1" or die $@; Module::Build::Compat->run_build_pl(args => \@ARGV); + my $build_script = 'Build'; + $build_script .= '.com' if $^O eq 'VMS'; + exit(0) unless(-e $build_script); # cpantesters convention require Module::Build; Module::Build::Compat->write_makefile(build_class => 'Module::Build'); diff -Naur Catalyst-Plugin-RequireSSL-0.06/MANIFEST Catalyst-Plugin-RequireSSL-0.06.new/MANIFEST --- Catalyst-Plugin-RequireSSL-0.06/MANIFEST 2007-03-06 15:45:35.000000000 +0000 +++ Catalyst-Plugin-RequireSSL-0.06.new/MANIFEST 2009-12-22 11:56:31.920552182 +0000 @@ -12,4 +12,5 @@ t/05ssl_host.t t/06remain_in_ssl.t t/lib/TestApp.pm -t/lib/TestApp/C/SSL.pm +t/lib/TestApp/Controller/Root.pm +t/lib/TestApp/Controller/SSL.pm diff -Naur Catalyst-Plugin-RequireSSL-0.06/META.yml Catalyst-Plugin-RequireSSL-0.06.new/META.yml --- Catalyst-Plugin-RequireSSL-0.06/META.yml 2007-03-06 15:45:35.000000000 +0000 +++ Catalyst-Plugin-RequireSSL-0.06.new/META.yml 2009-12-22 11:56:44.049306493 +0000 @@ -9,11 +9,13 @@ license: http://dev.perl.org/licenses/ requires: Catalyst: 5.23 +configure_requires: + Module::Build: 0.35 provides: Catalyst::Plugin::RequireSSL: file: lib/Catalyst/Plugin/RequireSSL.pm version: 0.06 -generated_by: Module::Build version 0.2806 +generated_by: Module::Build version 0.35 meta-spec: - url: http://module-build.sourceforge.net/META-spec-v1.2.html - version: 1.2 + url: http://module-build.sourceforge.net/META-spec-v1.4.html + version: 1.4 diff -Naur Catalyst-Plugin-RequireSSL-0.06/t/lib/TestApp/C/SSL.pm Catalyst-Plugin-RequireSSL-0.06.new/t/lib/TestApp/C/SSL.pm --- Catalyst-Plugin-RequireSSL-0.06/t/lib/TestApp/C/SSL.pm 2007-03-06 15:45:35.000000000 +0000 +++ Catalyst-Plugin-RequireSSL-0.06.new/t/lib/TestApp/C/SSL.pm 1970-01-01 01:00:00.000000000 +0100 @@ -1,20 +0,0 @@ -package TestApp::C::SSL; - -use strict; -use base 'Catalyst::Base'; - -sub secured : Local { - my ( $self, $c ) = @_; - - $c->require_ssl; - - $c->res->output( 'Secured' ); -} - -sub unsecured : Local { - my ( $self, $c ) = @_; - - $c->res->output( 'Unsecured' ); -} - -1; diff -Naur Catalyst-Plugin-RequireSSL-0.06/t/lib/TestApp/Controller/Root.pm Catalyst-Plugin-RequireSSL-0.06.new/t/lib/TestApp/Controller/Root.pm --- Catalyst-Plugin-RequireSSL-0.06/t/lib/TestApp/Controller/Root.pm 1970-01-01 01:00:00.000000000 +0100 +++ Catalyst-Plugin-RequireSSL-0.06.new/t/lib/TestApp/Controller/Root.pm 2009-12-22 11:41:28.269926322 +0000 @@ -0,0 +1,10 @@ +package TestApp::Controller::Root; + +use strict; +use base 'Catalyst::Controller'; + +sub default : Private { + my ( $self, $c ) = @_; +} + +1; diff -Naur Catalyst-Plugin-RequireSSL-0.06/t/lib/TestApp/Controller/SSL.pm Catalyst-Plugin-RequireSSL-0.06.new/t/lib/TestApp/Controller/SSL.pm --- Catalyst-Plugin-RequireSSL-0.06/t/lib/TestApp/Controller/SSL.pm 1970-01-01 01:00:00.000000000 +0100 +++ Catalyst-Plugin-RequireSSL-0.06.new/t/lib/TestApp/Controller/SSL.pm 2009-12-22 11:19:51.158676285 +0000 @@ -0,0 +1,20 @@ +package TestApp::Controller::SSL; + +use strict; +use base 'Catalyst::Controller'; + +sub secured : Local { + my ( $self, $c ) = @_; + + $c->require_ssl; + + $c->res->output( 'Secured' ); +} + +sub unsecured : Local { + my ( $self, $c ) = @_; + + $c->res->output( 'Unsecured' ); +} + +1; diff -Naur Catalyst-Plugin-RequireSSL-0.06/t/lib/TestApp.pm Catalyst-Plugin-RequireSSL-0.06.new/t/lib/TestApp.pm --- Catalyst-Plugin-RequireSSL-0.06/t/lib/TestApp.pm 2007-03-06 15:45:35.000000000 +0000 +++ Catalyst-Plugin-RequireSSL-0.06.new/t/lib/TestApp.pm 2009-12-22 11:41:20.419301553 +0000 @@ -12,9 +12,4 @@ TestApp->setup( qw/RequireSSL/ ); -sub default : Private { - my ( $self, $c ) = @_; - -} - 1;