Skip Menu |

This queue is for tickets about the Spreadsheet-ParseExcel-Simple CPAN distribution.

Report information
The Basics
Id: 52792
Status: open
Priority: 0/
Queue: Spreadsheet-ParseExcel-Simple
People
Owner: Nobody in particular
Requestors: MARKSTOS [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.04
Fixed in: (no value)

History Show all quoted text
  Tue Dec 15 14:42:43 2009 MARKSTOS [...] cpan.org - Ticket created
Subject: parse failure reason is not accessable when read() fails
Thanks for this module, I find it useful. Here's a suggestion to improve it. When the read() method fails, "undef" is returned. There is currently no way to access a diagnostic message of *why* the parsing fails. It's important to know at least whether the input file was bad of if there was perhaps some other internal reason for not being able to complete the parsing. A way should added to access this. Thanks! Mark
  Tue Dec 15 15:10:13 2009 tony [...] tmtm.com - Correspondence added
Subject: Re: [rt.cpan.org #52792] parse failure reason is not accessable when read() fails
Date: Tue, 15 Dec 2009 21:09:26 +0100
To: bug-Spreadsheet-ParseExcel-Simple [...] rt.cpan.org
From: Tony Bowden <tony [...] tmtm.com>
On Tue, Dec 15, 2009 at 8:42 PM, MARKSTOS via RT <bug-Spreadsheet-ParseExcel-Simple@rt.cpan.org> wrote: Show quoted text
> When the read() method fails, "undef" is returned. There is currently no > way to access a diagnostic message of *why* the parsing fails. It's > important to know at least whether the input file was bad of if there was > perhaps some other internal reason for not being able to complete the > parsing. > A way should added to access this.
Patches welcome. Thanks, Tony
  Tue Dec 15 15:10:14 2009 The RT System itself - Status changed from 'new' to 'open'
  Tue Dec 15 15:19:25 2009 mark [...] summersault.com - Correspondence added
Subject: Re: [rt.cpan.org #52792] parse failure reason is not accessable when read() fails
Date: Tue, 15 Dec 2009 15:18:15 -0500
To: bug-Spreadsheet-ParseExcel-Simple [...] rt.cpan.org
From: Mark Stosberg <mark [...] summersault.com>
On Tue, 15 Dec 2009 15:10:15 -0500 "tony@tmtm.com via RT" <bug-Spreadsheet-ParseExcel-Simple@rt.cpan.org> wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=52792 > > > On Tue, Dec 15, 2009 at 8:42 PM, MARKSTOS via RT > <bug-Spreadsheet-ParseExcel-Simple@rt.cpan.org> wrote:
> > When the read() method fails, "undef" is returned. There is currently no > > way to access a diagnostic message of *why* the parsing fails. It's > > important to know at least whether the input file was bad of if there was > > perhaps some other internal reason for not being able to complete the > > parsing. > > A way should added to access this.
> > Patches welcome.
Got it. Would you be OK with a change that caused 'read()' to die with the diagnostic if there is an error... instead of returning "undef" as it does now? Mark
  Tue Dec 15 16:06:48 2009 tony [...] tmtm.com - Correspondence added
Subject: Re: [rt.cpan.org #52792] parse failure reason is not accessable when read() fails
Date: Tue, 15 Dec 2009 22:05:28 +0100
To: bug-Spreadsheet-ParseExcel-Simple [...] rt.cpan.org
From: Tony Bowden <tony [...] tmtm.com>
On Tue, Dec 15, 2009 at 9:19 PM, mark@summersault.com via RT <bug-Spreadsheet-ParseExcel-Simple@rt.cpan.org> wrote: Show quoted text
> Got it. Would you be OK with a change that caused 'read()' to die with > the diagnostic if there is an error... instead of returning "undef" as > it does now?
Probably not — this should really continue to mirror the Spreadsheet::ParseExcel interface with a 'read or die' idiom. Tony