| Subject: | wrong number of skipped tests in forks08.t |
The 2 blocks for skippable tests have 2 tests in them, but the skip statement only says to skip 1. This can lead to
failed tests. (My solaris test tries to skip the nanosleep ones)
perl -v
This is perl, v5.8.4 built for i86pc-solaris-64int
(with 31 registered patches, see perl -V for more detail)
SunOS <host> 5.10 Generic_137112-05 i86pc i386 i86pc
$ diff -u forks08.t.orig forks08.t
--- forks08.t.orig Tue Dec 15 10:30:18 2009
+++ forks08.t Tue Dec 15 10:29:57 2009
@@ -72,7 +72,7 @@
# Check that main thread waits full 5 seconds after CHLD signal
SKIP: {
- skip('usleep not supported on this platform',1) unless &Time::HiRes::d_usleep && defined(my $t = eval {
&Time::HiRes::usleep(0) }) && !$@;
+ skip('usleep not supported on this platform',2) unless &Time::HiRes::d_usleep && defined(my $t = eval {
&Time::HiRes::usleep(0) }) && !$@;
$t1 = threads->new(sub { sleep 1; });
$time = &Time::HiRes::usleep(5000000);
$t1->join();
@@ -83,7 +83,7 @@
# Check that main thread waits full 5 seconds after CHLD signal
SKIP: {
- skip('Time::HiRes::nanosleep function not supported on this platform',1)
+ skip('Time::HiRes::nanosleep function not supported on this platform',2)
unless &Time::HiRes::d_nanosleep && defined(my $t = eval { &Time::HiRes::nanosleep(0) }) && !$@;
$t1 = threads->new(sub { sleep 1; });
$time = &Time::HiRes::nanosleep(5000000000);