Skip Menu |

This queue is for tickets about the Geo-Coder-GoogleMaps CPAN distribution.

Report information
The Basics
Id: 52711
Status: resolved
Priority: 0/
Queue: Geo-Coder-GoogleMaps

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: Rename Serialyze to Serialize
The method name "Serialyze" looks like it has a typo in it. It should probably be "Serialize". See the attached patch. Regards, Slaven
Subject: 0002--renamed-Serialyze-to-Serialize.patch
From 975bfe82a83e9ae14ccd062653fdc89384f09c53 Mon Sep 17 00:00:00 2001 From: Slaven Rezic <slaven@rezic.de> Date: Sat, 12 Dec 2009 16:04:41 +0100 Subject: [PATCH 2/2] - renamed Serialyze to Serialize --- demo/geocode.pl | 2 +- lib/Geo/Coder/GoogleMaps.pm | 2 +- lib/Geo/Coder/GoogleMaps/Location.pm | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) mode change 100644 => 100755 demo/geocode.pl diff --git a/demo/geocode.pl b/demo/geocode.pl old mode 100644 new mode 100755 index db433fc..c3d23b7 --- a/demo/geocode.pl +++ b/demo/geocode.pl @@ -15,7 +15,7 @@ if($@){ die "Error while geocoding :\n\t$@\n"; } else { $location = $response->placemarks()->[0]; - print "Location:\n",$location->Serialyze(1),"\n"; + print "Location:\n",$location->Serialize(1),"\n"; } print "North: ",$location->LLB_north,"\nSouth: ",$location->LLB_south,"\n East: ",$location->LLB_east,"\n West: ",$location->LLB_west,"\n"; diff --git a/lib/Geo/Coder/GoogleMaps.pm b/lib/Geo/Coder/GoogleMaps.pm index 82a0639..fd8ab33 100644 --- a/lib/Geo/Coder/GoogleMaps.pm +++ b/lib/Geo/Coder/GoogleMaps.pm @@ -93,7 +93,7 @@ WARNING WARNING WARNING Get a location from the Google Maps API. It return a L<Geo::Coder::GoogleMaps::Response> object. my $response = $gmap->geocode(location => '88 rue du chateau, 92600, Asnières sur seine, France'); - print $response->placemarks()->[0]->Serialyze(1) if( $response->is_success() ) ; + print $response->placemarks()->[0]->Serialize(1) if( $response->is_success() ) ; Please note that for the moment the geocode methode rely on JSON::Syck to parse the Google's output and ask for result in JSON format. diff --git a/lib/Geo/Coder/GoogleMaps/Location.pm b/lib/Geo/Coder/GoogleMaps/Location.pm index 8ae80a2..6208ed4 100644 --- a/lib/Geo/Coder/GoogleMaps/Location.pm +++ b/lib/Geo/Coder/GoogleMaps/Location.pm @@ -425,17 +425,17 @@ sub toXML { return shift->toKML(@_); } -=head2 Serialyze +=head2 Serialize This method simply call the good to(JSON|XML|KML) depending of the output format you selected. You can eventually pass extra arguments, they will be relayed. - $location->Serialyze(1); # if the output is set to XML or KML you will have a stringified XML as output + $location->Serialize(1); # if the output is set to XML or KML you will have a stringified XML as output =cut -sub Serialyze { +sub Serialize { my $self = shift; if($self->{output}){ return $self->toJSON if($self->{output} eq 'json'); @@ -514,4 +514,4 @@ This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. =cut -1; # end of Geo::Coder::GoogleMaps::Location \ No newline at end of file +1; # end of Geo::Coder::GoogleMaps::Location -- 1.6.1
This is fixed in 0.4 version, thanks to your patch ! Thank you very much !