Bug #52661 for Sepia: info_dir parsing broken

Thu Dec 10 23:10:13 2009 ANDK [...] cpan.org - Ticket created

Subject:

info_dir parsing broken

My emacs spits out diagnostics during startup. Here is a walk through the debugger to illustrate what goes wrong on my smoker during 'perl Makefile.PL': DB<4> main::(Makefile.PL:57): $install_info = quotemeta prompt("install-info program?", 'install-info'); DB<4> install-info program? [install-info] main::(Makefile.PL:58): $info_dir = `$emacs --batch --eval '(progn (require (quote info)) (message "\%s" (car Info-default-directory-list)))' 2>&1`; DB<4> main::(Makefile.PL:59): chomp $info_dir; DB<4> x $info_dir 0 'Loading 00debian-vars... Loading /etc/emacs/site-start.d/20apel.el (source)... Loading /etc/emacs/site-start.d/50dictionaries-common.el (source)... Loading debian-ispell... Loading /var/cache/dictionaries-common/emacsen-ispell-default.el (source)... Loading /var/cache/dictionaries-common/emacsen-ispell-dicts.el (source)... Loading /etc/emacs/site-start.d/50emacs-goodies-el.el (source)... Loading /etc/emacs/site-start.d/50emacs-intl-fonts.el (source)... Loading /etc/emacs/site-start.d/50flim.el (source)... Loading /etc/emacs/site-start.d/50git-core.el (source)... Loading /etc/emacs/site-start.d/50org-mode.el (source)... Loading /etc/emacs/site-start.d/50psvn.el (source)... Loading /etc/emacs/site-start.d/50w3m-el.el (source)... /usr/local/share/info/ ' DB<5> n main::(Makefile.PL:60): $info_dir = prompt("Info directory?", $info_dir); DB<5> n Info directory? [Loading 00debian-vars... Loading /etc/emacs/site-start.d/20apel.el (source)... Loading /etc/emacs/site-start.d/50dictionaries-common.el (source)... Loading debian-ispell... Loading /var/cache/dictionaries-common/emacsen-ispell-default.el (source)... Loading /var/cache/dictionaries-common/emacsen-ispell-dicts.el (source)... Loading /etc/emacs/site-start.d/50emacs-goodies-el.el (source)... Loading /etc/emacs/site-start.d/50emacs-intl-fonts.el (source)... Loading /etc/emacs/site-start.d/50flim.el (source)... Loading /etc/emacs/site-start.d/50git-core.el (source)... Loading /etc/emacs/site-start.d/50org-mode.el (source)... Loading /etc/emacs/site-start.d/50psvn.el (source)... Loading /etc/emacs/site-start.d/50w3m-el.el (source)... /usr/local/share/info/] n main::(Makefile.PL:61): if (!-d $info_dir) { DB<5> n main::(Makefile.PL:62): warn "Not installing info files.\n"; HTH & Regards,

Sun Mar 13 10:51:25 2011 seano [...] cpan.org - Correspondence added

Thanks for the report. Does the attached patch fix it?

Subject:

info.diff

diff --git a/Makefile.PL b/Makefile.PL index 5a4913a..101716b 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -95,11 +95,10 @@ sub prompt_for_sitelisp sub prompt_for_infodir { - my $info_dir = run_elisp( $ELISP_FIND_INFODIR ); - chomp $info_dir; + chomp(my @info_dir = grep { m!/info/?$! } run_elisp( $ELISP_FIND_INFODIR )); # pass prompt undef so it will not display brackets if $info_dir is "" - $info_dir = prompt("Info directory?", $info_dir || undef); + my $info_dir = prompt("Info directory?", $info_dir[0] || undef); return escape_path( $info_dir ); }

Sun Mar 13 10:51:26 2011 The RT System itself - Status changed from 'new' to 'open'

Sun Mar 13 10:51:27 2011 seano [...] cpan.org - Given to SEANO

Sun Mar 13 16:19:00 2011 ANDK [...] cpan.org - Correspondence added

~/.cpan/build/Sepia-0.991_02-Ml7228% patch -p1 < info.diff patching file Makefile.PL Hunk #1 FAILED at 95. 1 out of 1 hunk FAILED -- saving rejects to file Makefile.PL.rej Maybe you better make a 0.991_03 release? Cpantesters reports are then produced quickly and automatically.

Sun Mar 13 18:56:14 2011 educated_foo [...] yahoo.com - Correspondence added

Subject:	Re: [rt.cpan.org #52661] info_dir parsing broken
Date:	Sun, 13 Mar 2011 15:56:06 -0700 (PDT)
To:	bug-sepia [...] rt.cpan.org
From:	Sean <educated_foo [...] yahoo.com>

Show quoted text

> Maybe you better make a 0.991_03 release? Cpantesters reports are then > produced quickly and automatically.

Will do -- I hadn't remembered that the Makefile.PL had changed much. /s

Tue Mar 15 09:28:57 2011 seano [...] cpan.org - Correspondence added

On Sun Mar 13 16:19:00 2011, ANDK wrote: Show quoted text

> Maybe you better make a 0.991_03 release? Cpantesters reports are then > produced quickly and automatically.

I don't think any of the Cpantesters machines has an emacs configured like yours to be verbose on startup, but I believe the problem is fixed in 0.991_05. If you can check that it is, I'll close this out.

Tue Mar 15 23:19:04 2011 ANDK [...] cpan.org - Correspondence added

Excellent! My smoker has sent out 18 pass and 1 fail. The fail is with perl-5.6.2 and probably has a different reason. Matrix: http://matrix.cpantesters.org/?dist=Sepia&maxver= My report on 5.6.2: http://www.cpantesters.org/cpan/report/abb077f6-4eaf-11e0-b97f-e0b99dcd942a Thank you very much!

Wed Mar 16 08:33:56 2011 seano [...] cpan.org - Correspondence added

Thanks for working with me on this. I looked at the 5.6.2 failure, and it looks weird, so I think I'll "fix" it by requiring 5.8.

Wed Mar 16 08:33:56 2011 seano [...] cpan.org - Status changed from 'open' to 'resolved'