Skip Menu |

This queue is for tickets about the Module-Build CPAN distribution.

Report information
The Basics
Id: 52647
Status: resolved
Priority: 0/
Queue: Module-Build
People
Owner: Nobody in particular
Requestors: daxim [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.35_13
Fixed in: 0.36

History Show all quoted text
  Thu Dec 10 07:34:47 2009 daxim [...] cpan.org - Ticket created
Subject: need an easy way to disable share_dir
The distro Xacobeo has a share directory, but uses it in a different way than intended by the share_dir feature. We also have darkpan distros that are structured the same way. Once M::B has detected a share/ subdir, it can't be easily persuaded to not copy the files to auto/. Things that work: setting share_dir to a nonsense value/not existing directory; subclassing M::B and nuking the functionality. Inhibiting should be easier. My colleague has a stronger opinion: that by default M::B should not magically act on a share/ alone, but require an explicit trigger, e.g. setting the share_dir option manually in Build.PL.
  Thu Dec 10 08:24:27 2009 dagolden [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #52647] need an easy way to disable share_dir
Date: Thu, 10 Dec 2009 08:23:42 -0500
To: bug-Module-Build [...] rt.cpan.org
From: David Golden <dagolden [...] cpan.org>
On Thu, Dec 10, 2009 at 7:34 AM, Lars Dɪᴇᴄᴋᴏᴡ 迪拉斯 via RT <bug-Module-Build@rt.cpan.org> wrote: Show quoted text
> Once M::B has detected a share/ subdir, it can't be easily persuaded to > not copy the files to auto/. Things that work: setting share_dir to a > nonsense value/not existing directory; subclassing M::B and nuking the > functionality. Inhibiting should be easier. > > My colleague has a stronger opinion: that by default M::B should not > magically act on a share/ alone, but require an explicit trigger, e.g. > setting the share_dir option manually in Build.PL.
The general trend in Perl distribution generation is more auto-sensing and less manual maintenance in *.PL. This is a louder "demand" from the author community. That said, disabling the behavior should be easier *and* documented. It should probably issue a note to the terminal as well so users aren't taken by surprise. I'll look into it. -- David
  Thu Dec 10 08:24:28 2009 The RT System itself - Status changed from 'new' to 'open'
  Thu Dec 17 16:44:28 2009 dagolden [...] cpan.org - Correspondence added
I have disable 'share_dir' using 'share' as a default in 0.35_14. 'share_dir' now always has to be specified explicitly
  Thu Dec 17 16:44:29 2009 dagolden [...] cpan.org - Status changed from 'open' to 'patched'
  Mon Dec 21 13:51:32 2009 dagolden [...] cpan.org - Status changed from 'patched' to 'resolved'
  Mon Dec 21 13:51:33 2009 dagolden [...] cpan.org - Fixed in 0.36 added