Skip Menu |

This queue is for tickets about the Catalyst-Action-REST CPAN distribution.

Report information
The Basics
Id: 52642
Status: rejected
Priority: 0/
Queue: Catalyst-Action-REST
People
Owner: Nobody in particular
Requestors: ddascalescu+perl [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: Unimportant
Broken in: 0.78
Fixed in: (no value)

History Show all quoted text
  Thu Dec 10 02:31:32 2009 ddascalescu+perl [...] gmail.com - Ticket created
Subject: Odd code comparing $rc to 0 or 1 using eq
In Catalyst::Action::Serialize, lines 48 and 50. http://github.com/bobtfish/catalyst-action-rest/blob/master/lib/Catalyst/Action/Serialize.pm#L48
  Thu Dec 10 19:50:15 2009 bobtfish [...] bobtfish.net - Correspondence added
I don't see what is 'odd' about it. A text exception is returned if the serialize has issues. 0 is returned for unsupported media 1 is returned for ok Therefore you need to string compare 0 (avoiding warnings if the string is an exception), and string compres ne 1.. It's not the API design I'd have _chosen_ myself, but it makes perfect sense (and the fact that string not numeric comparison is being used makes sense). Cheers t0m
  Thu Dec 10 19:50:16 2009 The RT System itself - Status changed from 'new' to 'open'
  Thu Dec 10 19:50:16 2009 bobtfish [...] bobtfish.net - Status changed from 'open' to 'rejected'