Bug #52640 for Archive-Extract: Make all the globals object attributes

Thu Dec 10 01:33:20 2009 mschwern [...] cpan.org - Ticket created

Subject:

Make all the globals object attributes

It would be very nice if I could safely change the behavior of an Archive::Extract object without having to localize globals before every use. For example: my $ae = Archive::Extract->new( archive => $file, prefer_bin => 1 ); ...and then later... $ae->extract( to => $dir ); as opposed to: my $ae = Archive::Extract->new( archive => $file, ); ...and then later... local $Archive::Extract::PREFER_BIN = 1; $ae->extract( to => $dir ); This would apply to debug, warn and prefer_bin. The object would use the global flags as a defaults.

Thu Dec 10 02:59:42 2009 mschwern [...] cpan.org - Correspondence added

And here's a patch. There's a few wacky localized uses of $WARN in the code that I don't know what to do with.

Message body is not shown because it is too large.

Thu Dec 10 02:59:44 2009 mschwern [...] cpan.org - Status changed from 'new' to 'open'

Wed Aug 25 13:48:32 2010 kane [...] cpan.org - Correspondence added

On Thu Dec 10 01:33:20 2009, MSCHWERN wrote: Show quoted text

> It would be very nice if I could safely change the behavior of an > Archive::Extract object without having to localize globals before every > use. For example: > > my $ae = Archive::Extract->new( > archive => $file, > prefer_bin => 1 > ); > > ...and then later... > $ae->extract( to => $dir ); > > as opposed to: > > my $ae = Archive::Extract->new( > archive => $file, > ); > > ...and then later... > local $Archive::Extract::PREFER_BIN = 1; > $ae->extract( to => $dir ); > > This would apply to debug, warn and prefer_bin. The object would use > the global flags as a defaults.

This would be backwards incompatible however; the value of 'prefer_bin' for extract would now be set at ->new time, not at ->extract time as in your previous example. Meaning the old code of: Show quoted text

> my $ae = Archive::Extract->new( archive => $file ); > local $Archive::Extract::PREFER_BIN = 1; > $ae->extract( to => $dir );

would not actually use the commandline tools. I'm happy to take the patch if the old behaviour can be supported as well. This probably means checking if ->new( prefer_bin ... ) was passed at ->extract time. Thanks for the patch and the clear UI improvement that you suggest.