Skip Menu |

This queue is for tickets about the TAP-Formatter-JUnit CPAN distribution.

Report information
The Basics
Id: 52629
Status: resolved
Priority: 0/
Queue: TAP-Formatter-JUnit
People
Owner: Nobody in particular
Requestors: mcmahon [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.05

History Show all quoted text
  Wed Dec 09 21:06:35 2009 mcmahon [...] cpan.org - Ticket created
Subject: Patch to support "bad" (non-ASCII) characters in generated JUnit XML
Hudson's XML parsing is very finicky about the characters it will accept. The attached patch adds a step that cleans the living daylights out of the incoming TAP to ensure that no matter what weird stuff the tests print, things continue to work. (JSON-Any in particular does this.) In addition, tap2junit now also accepts '-' as a valid filename, and reads from STDIN and writes to STDOUT. Other file processing remains the same, so mixing '-' and actual files works. The tests have been modified slightly to use FindBin to locate items that used to use relative paths, and all the tests have '-Iblib/lib' on their Perl invocations to ensure that we're testing the modules we're working on. It also upgrades the file from 0.02 to 0.03. Thanks for writing it! It's made setting up Hudson a lot simpler.
Subject: TAP-JUnit-Formatter.patch

Message body is not shown because it is too large.

  Wed Jan 13 18:57:17 2010 GTERMARS [...] cpan.org - Correspondence added
Joe, *many* thanks for the patch. And, my apologies for the tardiness in my reply. I've integrated most of the changes that you'd included in this patch, although I did rework some of them a bit. Interface wise, though, the patches I've integrated should behave the same as what you'd submitted in this patch. Only thing I didn't integrate was the FindBin changes, but only because I had a different patch applied which changed it to use "blib/lib/" and "blib/script/" properly (instead of "lib/" and "bin/"). I've _just_ uploaded a v0.04 release to PAUSE, which should make its way out shortly. Only question I had was w.r.t. the "FindBin" changes that you'd made; what platform are you running the tests on/under which was causing them to not pick up the relative paths correctly?
  Wed Jan 13 18:57:18 2010 The RT System itself - Status changed from 'new' to 'open'
  Wed Jan 13 18:57:18 2010 GTERMARS [...] cpan.org - Status changed from 'open' to 'resolved'
  Wed Jan 13 23:30:22 2010 joe.mcmahon [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #52629] Patch to support "bad" (non-ASCII) characters in generated JUnit XML
Date: Wed, 13 Jan 2010 20:29:44 -0800
To: bug-TAP-Formatter-JUnit [...] rt.cpan.org
From: Joe McMahon <joe.mcmahon [...] gmail.com>
On Jan 13, 2010, at 3:57 PM, Graham TerMarsch via RT wrote: Show quoted text
> Only question I had was w.r.t. the "FindBin" changes that you'd made; > what platform are you running the tests on/under which was causing them > to not pick up the relative paths correctly?
Oh, I've just gotten into the habit of using FindBin because that way I can run from whatever directory I happen to be in. Not a critical change at all.
  Wed Jan 13 23:30:30 2010 The RT System itself - Status changed from 'resolved' to 'open'
  Thu Jan 14 12:47:04 2010 GTERMARS [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Jan 14 12:47:05 2010 GTERMARS [...] cpan.org - Fixed in 0.05 added
  Thu Jan 14 12:47:05 2010 GTERMARS [...] cpan.org - Fixed in 0.02 deleted