| Subject: | Bug in Net-Google-SafeBrowsing-Blocklist-1.04 |
| Date: | Wed, 09 Dec 2009 16:58:11 +0100 |
| To: | bug-Net-Google-SafeBrowsing-Blocklist [...] rt.cpan.org |
| From: | Tchesmeli Serge <stchesmeli.ext [...] orange-ftgroup.com> |
Hello,
Excuse my poor enlish, i'm a french user ;)
first of all thanks for your Google safebrowsing module! I use it, but i
had to hack it to make it work.
Some uris blacklisted by google (and checked on
http://www.google.com/safebrowsing/diagnostic?site= ) didn't matched
with your module.
For example:
http://bigtopcabaret.cn:8080/cache/
http://liteautotop.cn/cache/
http://litebest.cn:8080/
And when i look at your module, i found in Blocklist.pm line 311 :
311 if (not defined($ip) and length($host_parts[$#host_parts]) == 2 {
312 --$max_hosts;
313 }
If i understand well your code, if the tld is on 2 char, max_hosts is
decrease. I don't understand why you do this, looking on API google safe
no such things are explained.
On uri like "http://liteautotop.cn/cache/", it result that your skip
"liteautotop" (--$max-hosts) and then the entire uri is skipped and
never tested.
I have commented line 311 to 313 and now all works.
Best regards,
Serge Tchesmeli