| Subject: | Wrong Documentation in Business::ISBN |
| Date: | Fri, 4 Dec 2009 15:08:57 +0100 |
| To: | bug-Business-ISBN [...] rt.cpan.org |
| From: | Martin Armbrecht <armbrecht [...] hbz-nrw.de> |
Dear developer of Business::ISBN,
I came across an error in the documentation of the OO-interface of
Business::ISBN to be seen on
http://search.cpan.org/~bdfoy/Business-ISBN-2.05/lib/ISBN.pm
It reads
---8<---
The constructor attempts to determine the group code and the publisher code.
If these data cannot be determined, the constructor sets $obj->is_valid to
something other than GOOD_ISBN. An object is still returned and it is up to
the program to check $obj->is_valid for one of five values (which may be
exported on demand). The actual values of these symbolic versions are the
same as those from previous versions of this module which used literal
values.
--->8---
A look at the code revealed that "sub is_valid()" actually returns either 1 or
undef. For the mentioned codes "sub error()" has to be called.
Would be great if you could fix that.
Thanks in advance, and thanks of course for writing the module in the first
place.
Regards
Martin
--
Martin Armbrecht
hbz - Hochschulbibliothekszentrum des Landes NRW, Gruppe Portale
Tel: (+49)(0)221 - 400 75 277
http://www.hbz-nrw.de