Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Pod-Simple CPAN distribution.

Report information
The Basics
Id: 52324
Status: resolved
Priority: 0/
Queue: Pod-Simple

People
Owner: Nobody in particular
Requestors: bohica [...] ntlworld.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: 3.11



Subject: since upgrade index not created
Hi, We moved our app from an old machine to a new one and all our generated html pages from the pod changed. We no longer get the nice index (linked table of contents) even though we set the index option. I think I tracked this down to a change in HTMLBatch.pm which in our working copy (3.05) does this: # Give each class a chance to init the converter: $page->batch_mode_page_object_init($self, $module, $infile, $outfile, $depth) if $page->can('batch_mode_page_object_init'); $self->batch_mode_page_object_init($page, $module, $infile, $outfile, $depth) if $self->can('batch_mode_page_object_init'); and in 3.10 does this: # Give each class a chance to init the converter: $page->batch_mode_page_object_init($self, $module, $infile, $outfile, $depth) if $page->can('batch_mode_page_object_init'); Adding the second line from 3.05 fixes the problem. FYI, this is what we were doing: perl '-MPod::Simple::HTMLBatch' '-e' 'Pod::Simple::HTMLBatch::go' 'lib' '../../../../public_html/BET' but I tried long handed like the following too: use Pod::Simple::HTMLBatch; my $bc = Pod::Simple::HTMLBatch->new(); $bc->verbose(5); $bc->index(1); $bc->no_contents_links(0); $bc->css_flurry(1); $bc->batch_convert("lib", "../../../../public_html/BET"); Martin -- Martin J. Evans Wetherby, UK
Subject: Re: [rt.cpan.org #52324] since upgrade index not created
Date: Tue, 1 Dec 2009 10:35:48 -0800
To: bug-Pod-Simple [...] rt.cpan.org
From: "David E. Wheeler" <dwheeler [...] cpan.org>
On Dec 1, 2009, at 7:48 AM, Martin J Evans via RT wrote: Show quoted text
> # Give each class a chance to init the converter: > > $page->batch_mode_page_object_init($self, $module, $infile, $outfile, > $depth) > if $page->can('batch_mode_page_object_init'); > $self->batch_mode_page_object_init($page, $module, $infile, $outfile, > $depth) > if $self->can('batch_mode_page_object_init');
Bah! I removed that line because I thought it was the same. I just stared at it again for 10 minutes before I finally saw that the first argument to batch_mode_page_object_init() in each was different. D'oh! So I've added a test to make sure that the index is created and restored that line. Thanks for the report. I'll see about getting into the core in time for Perl 5.12. David
No problem David - it is not causing us any issue as we've fixed it locally - shame it took us so long to find it though - three cheers to my colleague Jason who eventually found it. Martin -- Martin J. Evans Wetherby, UK
Subject: Re: [rt.cpan.org #52324] since upgrade index not created
Date: Tue, 1 Dec 2009 11:50:33 -0800
To: bug-Pod-Simple [...] rt.cpan.org
From: "David E. Wheeler" <david [...] justatheory.com>
On Dec 1, 2009, at 11:20 AM, Martin J Evans via RT wrote: Show quoted text
> No problem David - it is not causing us any issue as we've fixed it > locally - shame it took us so long to find it though - three cheers to > my colleague Jason who eventually found it.
Three cheers indeed. Made my job of fixing the issue much easier. Best, David