| Subject: | t/10pod fails with libpod-simple-perl >=3.07 |
Hello,
I'm working on the Debian packaging for your Parse::DMIDecode.
I've got an issue with the pod in your code: L<text|http://someurl> is
not a valid pod syntax, see:
http://perldoc.perl.org/perlpod.html#Formatting-Codes
with libpod-simple-perl >=3.07 installed, make test fails:
t/10pod................NOK 1/4
# Failed test 'blib/lib/Parse/DMIDecode.pm'
# at /usr/share/perl5/Test/Pod.pm line 219.
# blib/lib/Parse/DMIDecode.pm (471): L<text|scheme:...> is invalid
according to perlpod
t/10pod................NOK 2/4
# Failed test 'blib/lib/Parse/DMIDecode/Handle.pm'
# at /usr/share/perl5/Test/Pod.pm line 219.
# blib/lib/Parse/DMIDecode/Handle.pm (425): L<text|scheme:...> is
invalid according to perlpod
t/10pod................NOK 4/4
# Failed test 'blib/lib/Parse/DMIDecode/Constants.pm'
# at /usr/share/perl5/Test/Pod.pm line 219.
# blib/lib/Parse/DMIDecode/Constants.pm (144): L<text|scheme:...> is
invalid according to perlpod
# Looks like you failed 3 tests of 4.
t/10pod................dubious
Test returned status 3 (wstat 768, 0x300)
DIED. FAILED tests 1-2, 4
Failed 3/4 tests, 25.00% okay
Please consider the attached patch.
Thanks for your code!
Pierre
| Subject: | fix-pod-urls.patch |
--- a/lib/Parse/DMIDecode.pm
+++ b/lib/Parse/DMIDecode.pm
@@ -466,9 +466,9 @@
L<http://perlgirl.org.uk>
If you like this software, why not show your appreciation by sending the
-author something nice from her
-L<Amazon wishlist|http://www.amazon.co.uk/gp/registry/1VZXC59ESWYK0?sort=priority>?
-( http://www.amazon.co.uk/gp/registry/1VZXC59ESWYK0?sort=priority )
+author something nice from her Amazon wishlist ?
+
+L<http://www.amazon.co.uk/gp/registry/1VZXC59ESWYK0?sort=priority>
=head1 COPYRIGHT
--- a/lib/Parse/DMIDecode/Constants.pm
+++ b/lib/Parse/DMIDecode/Constants.pm
@@ -139,9 +139,9 @@
L<http://perlgirl.org.uk>
If you like this software, why not show your appreciation by sending the
-author something nice from her
-L<Amazon wishlist|http://www.amazon.co.uk/gp/registry/1VZXC59ESWYK0?sort=priority>?
-( http://www.amazon.co.uk/gp/registry/1VZXC59ESWYK0?sort=priority )
+author something nice from her Amazon wishlist ?
+
+L<http://www.amazon.co.uk/gp/registry/1VZXC59ESWYK0?sort=priority>
=head1 COPYRIGHT
--- a/lib/Parse/DMIDecode/Handle.pm
+++ b/lib/Parse/DMIDecode/Handle.pm
@@ -420,9 +420,9 @@
L<http://perlgirl.org.uk>
If you like this software, why not show your appreciation by sending the
-author something nice from her
-L<Amazon wishlist|http://www.amazon.co.uk/gp/registry/1VZXC59ESWYK0?sort=priority>?
-( http://www.amazon.co.uk/gp/registry/1VZXC59ESWYK0?sort=priority )
+author something nice from her Amazon wishlist ?
+
+L<http://www.amazon.co.uk/gp/registry/1VZXC59ESWYK0?sort=priority>
=head1 COPYRIGHT