Skip Menu |

This queue is for tickets about the Test-WWW-Selenium CPAN distribution.

Report information
The Basics
Id: 51739
Status: resolved
Priority: 0/
Queue: Test-WWW-Selenium

People
Owner: Nobody in particular
Requestors: frequency [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 1.20
Fixed in: (no value)



Subject: Superfluous build dependency: Test::Pod
I thought I should file this as a separate bug since it's a separate issue. You removed the POD tests, however, Test::Pod is still in your build_requires. It doesn't really affect anything; but since the module isn't needed, it's probably more polite not to install it. Cheers, Jonathan
Subject: Re: [rt.cpan.org #51739] Superfluous build dependency: Test::Pod
Date: Thu, 19 Nov 2009 19:09:09 -0800
To: bug-Test-WWW-Selenium [...] rt.cpan.org
From: Luke Closs <lukecloss [...] gmail.com>
Jonathan are you on Github? I'll give you a commit bit if so. Luke On Thu, Nov 19, 2009 at 10:06 AM, Jonathan Yu via RT <bug-Test-WWW-Selenium@rt.cpan.org> wrote: Show quoted text
> Thu Nov 19 13:06:49 2009: Request 51739 was acted upon. > Transaction: Ticket created by FREQUENCY >       Queue: Test-WWW-Selenium >     Subject: Superfluous build dependency: Test::Pod >   Broken in: 1.20 >    Severity: Wishlist >       Owner: Nobody >  Requestors: frequency@cpan.org >      Status: new >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=51739 > > > > I thought I should file this as a separate bug since it's a separate issue. > > You removed the POD tests, however, Test::Pod is still in your > build_requires. > > It doesn't really affect anything; but since the module isn't needed, > it's probably more polite not to install it. > > Cheers, > > Jonathan >
Subject: Re: [rt.cpan.org #51739] Superfluous build dependency: Test::Pod
Date: Tue, 24 Nov 2009 09:04:38 -0500
To: bug-Test-WWW-Selenium [...] rt.cpan.org
From: Jonathan Yu <frequency [...] cpan.org>
On Thu, Nov 19, 2009 at 10:09 PM, Luke Closs via RT <bug-Test-WWW-Selenium@rt.cpan.org> wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=51739 > > > Jonathan are you on Github?  I'll give you a commit bit if so.
Technically, yes, but not really. You see, I do have an account on github, but I don't really know how to use git properly yet, and I haven't had the time to learn. I also don't think I'd be the best candidate for a commit bit, since I don't use Test::WWW::Selenium myself; I am just on the team that helps package it for Debian, and that's about my only experience with it. If you're too busy to fix this yourself, I can figure out how to use git. My username on github is jawnsy. Cheers! Show quoted text
> > Luke > > On Thu, Nov 19, 2009 at 10:06 AM, Jonathan Yu via RT > <bug-Test-WWW-Selenium@rt.cpan.org> wrote:
>> Thu Nov 19 13:06:49 2009: Request 51739 was acted upon. >> Transaction: Ticket created by FREQUENCY >>       Queue: Test-WWW-Selenium >>     Subject: Superfluous build dependency: Test::Pod >>   Broken in: 1.20 >>    Severity: Wishlist >>       Owner: Nobody >>  Requestors: frequency@cpan.org >>      Status: new >>  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=51739 > >> >> >> I thought I should file this as a separate bug since it's a separate issue. >> >> You removed the POD tests, however, Test::Pod is still in your >> build_requires. >> >> It doesn't really affect anything; but since the module isn't needed, >> it's probably more polite not to install it. >> >> Cheers, >> >> Jonathan >>
> >
Subject: patch ready for both of these and fix for t/test_default_server
Luke, I have combined these two patches plus added a fix that makes t/test_default_server.t independent of where the selenium-core distribution is; it downloads it and tests with the downloaded copy. (Currently it uses t/selenium-core for this, but that could be changed. I like it that way because it remains cached for further tests.) I've also made the POD fix and moved pod.t into xt/. This way the POD tests are still available but don't require casual users to run them. (We could remove the BuildRequires for Test::Pod as well, since developers will not fall over if they see that they need to download an extra module to run developer tests.) I can branch your project at github and push this fix to the branch so you can vet it before pulling into your master.
Subject: Re: [rt.cpan.org #51739] patch ready for both of these and fix for t/test_default_server
Date: Wed, 16 Jun 2010 20:49:15 -0700
To: bug-Test-WWW-Selenium [...] rt.cpan.org
From: Luke Closs <lukecloss [...] gmail.com>
Joe, Would you like to take over maintainership for this module? I don't have much time for it lately. I would be more than happy to give you a commit bit to my repo and/or make you a maintainer on CPAN. Luke On Wed, Jun 16, 2010 at 8:25 PM, Joe McMahon via RT <bug-Test-WWW-Selenium@rt.cpan.org> wrote: Show quoted text
>       Queue: Test-WWW-Selenium >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=51739 > > > Luke, I have combined these two patches plus added a fix that makes > t/test_default_server.t independent of where the selenium-core > distribution is; it downloads it and tests with the downloaded copy. > (Currently it uses t/selenium-core for this, but that could be changed. > I like it that way because it remains cached for further tests.) > > I've also made the POD fix and moved pod.t into xt/. This way the POD > tests are still available but don't require casual users to run them. > (We could remove the BuildRequires for Test::Pod as well, since > developers will not fall over if they see that they need to download an > extra module to run developer tests.) > > I can branch your project at github and push this fix to the branch so > you can vet it before pulling into your master. >
this is fixed in the repo and will be fixed in the upcoming 1.25 release. Thanks