Bug #5164 for XML-Validator-Schema: Element references that are in type definitions are never completed

Mon Feb 02 03:57:28 2004 JACOB [...] cpan.org - Ticket created

Subject:

Element references that are in type definitions are never completed

Element references that are in type definitions are never completed. (and maybe more, I don't fully understand the data store yet) The problem is that first the refs are completed then the types. But types can also contain refs, and these are forgotten because they are inserted after the ref completition run is done. I attached a test case and a patch against RootNode.pm. The patch may not be the most run-time efficient solution, I just loop over both completitions as long as they insert new elements into the tree (and restrict the completition loops to the newly inserted elements), but as said, I'm still trying to understand the data storage. Trying... ;)

Download RootNode.zip
application/zip 1.5k

Message body not shown because it is not plain text.

Thu Apr 15 05:52:38 2004 Guest - Correspondence added

From:

JACOB

[JACOB - Mon Feb 2 03:57:28 2004]: Show quoted text

> I attached a test case and a patch against

RootNode.pm. I found a small error in my patch, so here is a new one.

Download RootNode.diff2
application/octet-stream 2.2k

Message body not shown because it is not plain text.

Wed Apr 21 13:57:35 2004 SAMTREGAR [...] cpan.org - Correspondence added

[guest - Thu Apr 15 05:52:38 2004]: Show quoted text

> [JACOB - Mon Feb 2 03:57:28 2004]: >

> > I attached a test case and a patch against

> RootNode.pm. > > I found a small error in my patch, so here is a new one.

After applying your patch the test suite breaks: Deep recursion on subroutine "Tree::DAG_Node::walk_down" at /usr/local/lib/perl5/site_perl/5.6.1/Tree/DAG_Node.pm line 1754. Perhaps you created a cycle in the tree?

Wed Apr 21 14:48:48 2004 SAMTREGAR [...] cpan.org - Correspondence added

I've fixed the problem. The fix will be in the next release, likely coming out today. Thanks for the help!

Wed Apr 21 14:48:49 2004 SAMTREGAR [...] cpan.org - Status changed from 'new' to 'resolved'

Thu Apr 22 04:05:57 2004 Guest - Correspondence added

From:

JACOB

[SAMTREGAR - Wed Apr 21 14:48:48 2004]: Show quoted text

> I've fixed the problem. The fix will be in the

next release, likely Show quoted text

> coming out today. Thanks for the help!

Thank you, I just tested it. All our test now succeed. I really love the part about "(4 subtests UNEXPECTEDLY SUCCEEDED)" :-)

Thu Apr 22 04:05:58 2004 The RT System itself - Status changed from 'resolved' to 'open'

Wed Apr 28 15:58:20 2004 SAMTREGAR [...] cpan.org - Status changed from 'open' to 'resolved'