Show quoted text> Thanks. I've committed a fix for this. But do note that the jira stuff (and rt and bugzilla) has been deprecated in favor of your own regex. So you can fix this yourself right now with the proper regex in --ticket-map.
Good to know. I will start using --ticket-map. Thanks.
Show quoted text> Huh. Never heard of revprop, though it has clearly been in SVN for a while. What does SVN::Notify do with it now?
Just like normal Subversion properties, revprop's are key/value pairs associated with a path within SVN. However, revprops differ in that:
- they are associated with a specific revision
- are not versioned (there is no history of revprop changes)
To set a revprop, you would use the --revprop argument to "svn propset". See this manual page:
http://svnbook.red-bean.com/nightly/en/svn.ref.svn.c.propset.html
Since changing a revprop leaves no history, there is a need to notify others that someone else on the project has changed a revision property. We can implement notification in the post-revprop-change hook script, just like we do with SVN::Notify in the post-commit hook. Here is a link to the manual discussion about the hook:
http://svnbook.red-bean.com/nightly/en/svn.ref.reposhooks.post-revprop-change.html
The information given to the post-revprop-change hook is a bit different from post-commit:
- revision whose property was modifed
- username making the change
- name of the property changed
- change type: A, D, or M (added, deleted, modified)
- stdin is the previous value of the property
- "svnlook propget --revprop" can be used to get the current value of the property
Therefore, SVN::Notify would need to generate a slightly different email output for revprop's. The above bullets and then maybe the diff of the old and new property value.
So that is a short explanation of revprops and how SVN::Notify might handle them. One other piece of information is that the log for a commit is stored in a revprop called svn:log. Clients like TortoiseSVN give the user the ability to "Edit the log message." To the user, they don't know that they are running "svn propset --revprop svn:log" but that is what is going on under the hood when they edit a log message.
Let me know what you think.
Thanks again for your time.
David
On Nov 18, 2009, at 2:14 AM, David Wheeler via RT wrote:
Show quoted text> <URL:
http://rt.cpan.org/Ticket/Display.html?id=51620 >
>
> On Nov 18, 2009, at 5:06 AM, David Ferguson via RT wrote:
>
>> Hi, I have a bug report for you and a feature request.
>>
>> First, the bug report. The %_ticket_regexen for jira is wrong. Jira project names can have letters and numbers, not just letters in them. Therefore, the regexp for Jira should be:
>> '\b([A-Z0-9]+-\d+)\b'
>>
>> Notice that I added "0-9" in the first part. Without this change, "PRJ1234-111" is not recognized.
>
> Thanks. I've committed a fix for this. But do note that the jira stuff (and rt and bugzilla) has been deprecated in favor of your own regex. So you can fix this yourself right now with the proper regex in --ticket-map.
>
>> Second, the feature request. Please consider support for revprop-changes. I could use svnnotify to send the commit log out again, but it is not clear to users that this was a old commit with a change just to the log. I am investigating mailer.py, but I really like the ColorDiff output from SVN::Notify.
>
> Huh. Never heard of revprop, though it has clearly been in SVN for a while. What does SVN::Notify do with it now?
>
>> I appreciate all of your hard work. It is a very nice piece of software.
>
> Thanks!
>
> David
>
>
>
