Bug #51616 for Date-Calc: [Patch] POD nits

Tue Nov 17 14:36:46 2009 FWIE [...] cpan.org - Ticket created

Subject:

[Patch] POD nits

The attached patch (against 6.3) fixes some POD, which renders wrong, at least at search.cpan.org.

Subject:

diff

Download diff
application/octet-stream 955b

Message body not shown because it is not plain text.

Tue Dec 08 04:30:10 2009 STBEY [...] cpan.org - Correspondence added

On Tue Nov 17 14:36:46 2009, FWIE wrote: Show quoted text

> The attached patch (against 6.3) fixes some POD, which renders wrong, > at least at search.cpan.org.

It's on the TO DO list. Didn't you mean the following? diff --git a/lib/Date/Calc/Object.pod b/lib/Date/Calc/Object.pod index 2e8a539..065611b 100644 --- a/lib/Date/Calc/Object.pod +++ b/lib/Date/Calc/Object.pod @@ -1062,7 +1062,7 @@ the case of "string" conversions, but not in the case of "number" conversions). Otherwise, the global settings as defined by C<Language($lang);> -or C<Date::Calc->language($lang);> will be passed to your handler. +or C<Date::Calc-E<lt>language($lang);> will be passed to your handler. =item * @@ -1105,7 +1105,7 @@ the current setting (and never its number). BEWARE that in order to avoid possible conflicts between threads or modules running concurrently, you should NEVER use the global function C<Language($lang);> or the class method -C<Date::Calc->language($lang);> in this module! +C<Date::Calc-E<lt>language($lang);> in this module! The class method is retained only for backward compatibility and for convenience in stand-alone applications when it is

Tue Dec 08 04:30:11 2009 The RT System itself - Status changed from 'new' to 'open'

Tue Dec 08 04:31:30 2009 STBEY [...] cpan.org - Correspondence added

Show quoted text

> diff --git a/lib/Date/Calc/Object.pod b/lib/Date/Calc/Object.pod > index 2e8a539..065611b 100644 > --- a/lib/Date/Calc/Object.pod > +++ b/lib/Date/Calc/Object.pod > @@ -1062,7 +1062,7 @@ the case of "string" conversions, but not in the > case of "number" > conversions). > > Otherwise, the global settings as defined by C<Language($lang);> > -or C<Date::Calc->language($lang);> will be passed to your handler. > +or C<Date::Calc-E<lt>language($lang);> will be passed to your handler. > > =item * > > @@ -1105,7 +1105,7 @@ the current setting (and never its number). > BEWARE that in order to avoid possible conflicts between threads > or modules running concurrently, you should NEVER use the global > function C<Language($lang);> or the class method > -C<Date::Calc->language($lang);> in this module! > +C<Date::Calc-E<lt>language($lang);> in this module! > > The class method is retained only for backward compatibility > and for convenience in stand-alone applications when it is

Oops - I meant E<gt> instead of E<lt>, of course! :-)

Tue Dec 08 04:37:40 2009 frank.wiegand [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #51616] [Patch] POD nits
Date:	Tue, 08 Dec 2009 10:37:12 +0100
To:	bug-Date-Calc [...] rt.cpan.org
From:	Frank Wiegand <frank.wiegand [...] gmail.com>

Am Dienstag, den 08.12.2009, 04:30 -0500 schrieb Steffen Beyer via RT: Show quoted text

> Didn't you mean the following? > > diff --git a/lib/Date/Calc/Object.pod b/lib/Date/Calc/Object.pod > index 2e8a539..065611b 100644 > --- a/lib/Date/Calc/Object.pod > +++ b/lib/Date/Calc/Object.pod > @@ -1062,7 +1062,7 @@ the case of "string" conversions, but not in the > case of "number" > conversions). > > Otherwise, the global settings as defined by C<Language($lang);> > -or C<Date::Calc->language($lang);> will be passed to your handler. > +or C<Date::Calc-E<lt>language($lang);> will be passed to your handler.

C<< -> >> and C<-E<gt>> should render same: »->«, but the former is more readable, IMHO. Bye, Frank