Bug #51461 for Parse-MediaWikiDump: Warnings During Build

Wed Nov 11 23:35:39 2009 frequency [...] cpan.org - Ticket created

Subject:

Warnings During Build

Hi there: In at least the past few releases, building your module seems to result in warnings from Devel::Cycle (or inside Devel::Cycle; I'm not totally sure what is at fault). You might want to consider using Test::NoWarnings to make warnings fatal during testing (so PASSes with warnings become FAILs). You also might want to consider using Test::Warn if these warnings are actually intentional. In either case, it just gives people the assurance that you intended the behaviour. See this passing report (with warnings): http://www.nntp.perl.org/group/perl.cpan.testers/2009/11/msg5964979.html I am one of the people who maintain the package for this module in Debian. I'll wait a week to hear back from you and otherwise try to patch it myself, but I'm uncomfortable with uploading something that has warnings during build and I'd like to track down this issue with you. It should be noted that Carp::Always can be useful (it can dump a full stack trace on die, I think it might be able to be reconfigured to do the same for plain warnings). Thanks for your good work. Cheers, Jonathan

Wed Nov 11 23:50:53 2009 triddle [...] cpan.org - Correspondence added

Thanks for the note and for the pointers. The warning is safe; it's not intentional but it is also harmless. I believe you are referring to the "unhandled type GLOB" style warning message as that's the one I'm thinking of. I'll work on quieting the warning so the tests look clean and update this ticket when that's been done. It's nice to know someone is watching so carefully! Thanks again, Tyler Riddle On Wed Nov 11 23:35:39 2009, FREQUENCY wrote: Show quoted text

> Hi there: > > In at least the past few releases, building your module seems to result > in warnings from Devel::Cycle (or inside Devel::Cycle; I'm not totally > sure what is at fault). > > You might want to consider using Test::NoWarnings to make warnings fatal > during testing (so PASSes with warnings become FAILs). You also might > want to consider using Test::Warn if these warnings are actually > intentional. In either case, it just gives people the assurance that you > intended the behaviour. > > See this passing report (with warnings): > http://www.nntp.perl.org/group/perl.cpan.testers/2009/11/msg5964979.html > > I am one of the people who maintain the package for this module in > Debian. I'll wait a week to hear back from you and otherwise try to > patch it myself, but I'm uncomfortable with uploading something that has > warnings during build and I'd like to track down this issue with you. > > It should be noted that Carp::Always can be useful (it can dump a full > stack trace on die, I think it might be able to be reconfigured to do > the same for plain warnings). > > Thanks for your good work. > > Cheers, > > Jonathan

Wed Nov 11 23:50:54 2009 The RT System itself - Status changed from 'new' to 'open'

Sun Nov 15 12:50:02 2009 triddle [...] cpan.org - Correspondence added

I just released version 1.0.2 which uses Test::Warn to squelch the harmless warning. I'll wait about a week and close the ticket as resolved if I don't get any other responses. Thanks for keeping such a watchful eye over Debian. :-) Tyler

Sun Nov 15 12:50:05 2009 triddle [...] cpan.org - Status changed from 'open' to 'patched'

Sun Nov 15 12:53:35 2009 frequency [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #51461] Warnings During Build
Date:	Sun, 15 Nov 2009 12:53:16 -0500
To:	bug-Parse-MediaWikiDump [...] rt.cpan.org
From:	Jonathan Yu <frequency [...] cpan.org>

Hi Tyler: I just saw the release hit PAUSE: 12:41:42 * GumbyPAN CPAN Upload: Parse-MediaWikiDump-1.0.2 by TRIDDLE I'll update our version and rebuild it shortly, then close the bug once that's finished. We already have version 1.0.1 in Debian; libparse-mediawikidump-perl | 1.0.1-1 | unstable | source, all I'll leave it at that version for now (ie, we won't upload 1.0.2) since the warning is harmless and there haven't been any feature changes between the releases. Thanks for being a responsible maintainer and taking care of this minor bug so quickly! Cheers, Jonathan On Sun, Nov 15, 2009 at 12:50 PM, Tyler Riddle via RT <bug-Parse-MediaWikiDump@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=51461 > > > I just released version 1.0.2 which uses Test::Warn to squelch the harmless warning. I'll wait > about a week and close the ticket as resolved if I don't get any other responses. > > Thanks for keeping such a watchful eye over Debian. :-) > > Tyler >

Sun Nov 15 12:53:35 2009 The RT System itself - Status changed from 'patched' to 'open'

Sun Nov 15 13:12:18 2009 frequency [...] cpan.org - Correspondence added

Tyler: I've just tested the new release-- t/00-load.t ........................ ok t/30-links-compat.t ................ ok t/30-links.t ....................... ok t/30-pages.t ....................... ok t/30-revisions.t ................... ok t/40-pages-single-revision-only.t .. ok t/40-pre-factory.t ................. ok t/70-memory-cycle.t ................ ok All tests successful. Perfect. However, I can't help but wonder if the issue lies in Test::Memory::Cycle, then. You are in a better position than me to be the judge of that, though. You might want to forward it to the maintainer of that package. Anyway, thanks for the fix, I'll mark this as resolved now :) Cheers, Jonathan On Sun Nov 15 12:53:35 2009, FREQUENCY wrote: Show quoted text

> Hi Tyler: > > I just saw the release hit PAUSE: > 12:41:42 * GumbyPAN CPAN Upload: Parse-MediaWikiDump-1.0.2 by TRIDDLE > > I'll update our version and rebuild it shortly, then close the bug > once that's finished. We already have version 1.0.1 in Debian; > > libparse-mediawikidump-perl | 1.0.1-1 | unstable | source, all > > I'll leave it at that version for now (ie, we won't upload 1.0.2) > since the warning is harmless and there haven't been any feature > changes between the releases. > > Thanks for being a responsible maintainer and taking care of this > minor bug so quickly! > > Cheers, > > Jonathan > > On Sun, Nov 15, 2009 at 12:50 PM, Tyler Riddle via RT > <bug-Parse-MediaWikiDump@rt.cpan.org> wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=51461 > > > > > I just released version 1.0.2 which uses Test::Warn to squelch the

> harmless warning. I'll wait

> > about a week and close the ticket as resolved if I don't get any

> other responses.

> > > > Thanks for keeping such a watchful eye over Debian. :-) > > > > Tyler > >

Sun Nov 15 13:12:20 2009 frequency [...] cpan.org - Status changed from 'open' to 'resolved'