Skip Menu |

This queue is for tickets about the Business-OnlinePayment-Iridium CPAN distribution.

Report information
The Basics
Id: 51249
Status: resolved
Priority: 0/
Queue: Business-OnlinePayment-Iridium
People
Owner: wreis [...] cpan.org
Requestors: GHENRY [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Unimportant
Broken in: 0.05
Fixed in: (no value)

History Show all quoted text
  Mon Nov 09 16:13:12 2009 GHENRY [...] cpan.org - Ticket created
Subject: SYNOPSIS needs updating to show CV2
Will do a patch plus should we use Moose::Util::TypeConstraints to stop silly mistakes and do some validation on passed data? Not sure if that's the right tool to use. Or should we just do that in the application that is using Business::OnlinePayment::Iridium
  Fri Nov 20 08:06:18 2009 wreis [...] cpan.org - Taken
  Fri Nov 20 08:12:01 2009 wreis [...] cpan.org - Correspondence added
On Mon Nov 09 16:13:12 2009, GHENRY wrote: Show quoted text
> Will do a patch plus should we use Moose::Util::TypeConstraints to stop > silly mistakes and do some validation on passed data? Not sure if that's > the right tool to use. > > Or should we just do that in the application that is using > Business::OnlinePayment::Iridium
Usually i do that in application using custom Moose subtypes, as checking if the CardNumber is a valid card type with Business::CardInfo, then the end user of app has a chance to fix the form issues and submit again. What we have in BOP::Iridium is for simple validation, like checking the CardNumber is a integer.
  Fri Nov 20 08:12:02 2009 The RT System itself - Status changed from 'new' to 'open'
  Fri Nov 20 08:12:02 2009 wreis [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri Nov 20 08:46:17 2009 ghenry [...] suretecsystems.com - Correspondence added
Subject: Re: [rt.cpan.org #51249] SYNOPSIS needs updating to show CV2
Date: Fri, 20 Nov 2009 13:45:40 +0000
To: "Wallace Reis via RT" <bug-Business-OnlinePayment-Iridium [...] rt.cpan.org>
From: "Gavin Henry" <ghenry [...] suretecsystems.com>
Makes sense. Thought so. Cheers. Show quoted text
------Original Message------ From: Wallace Reis via RT To: GHENRY@cpan.org Subject: [rt.cpan.org #51249] SYNOPSIS needs updating to show CV2 Sent: 20 Nov 2009 13:12 <URL: https://rt.cpan.org/Ticket/Display.html?id=51249 > On Mon Nov 09 16:13:12 2009, GHENRY wrote:
> Will do a patch plus should we use Moose::Util::TypeConstraints to stop > silly mistakes and do some validation on passed data? Not sure if that's > the right tool to use. > > Or should we just do that in the application that is using > Business::OnlinePayment::Iridium
Usually i do that in application using custom Moose subtypes, as checking if the CardNumber is a valid card type with Business::CardInfo, then the end user of app has a chance to fix the form issues and submit again. What we have in BOP::Iridium is for simple validation, like checking the CardNumber is a integer. -- Kind Regards, Gavin Henry. Managing Director. T +44 (0) 1224 279484 M +44 (0) 7930 323266 F +44 (0) 1224 824887 E ghenry@suretecsystems.com Open Source. Open Solutions(tm). http://www.suretecsystems.com/ Suretec Systems is a limited company registered in Scotland. Registered number: SC258005. Registered office: 24 Cormack Park, Rothienorman, Inverurie, Aberdeenshire, AB51 8GL. Subject to disclaimer at http://www.suretecgroup.com/disclaimer.html
  Fri Nov 20 08:46:19 2009 The RT System itself - Status changed from 'resolved' to 'open'
  Thu Sep 09 13:43:55 2010 wreis [...] cpan.org - Status changed from 'open' to 'resolved'