| Subject: | Missing Carp (msg about croak) and POD error - Patch attached |
I just tried to install Jifty which needs Email::MIME::CreateHTML as a
prereq. I stumbled about some errors which are already listed in the
testers reports:
like: (taken from a CPAN Testers report)
# Failed test 'blib/lib/Email/MIME/CreateHTML.pm'
# at /home/stro/perl5100/lib/site_perl/5.10.0/Test/Pod.pm line 219.
# blib/lib/Email/MIME/CreateHTML.pm (661): L<text|scheme:...> is invalid
according to perlpod
# Looks like you failed 1 test of 5.
t/pod.t .............................
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/5 subtests
String found where operator expected at
/home/stro/.cpan.5100/build/Email-MIME-CreateHTML-1.026-v5KGXZ/blib/lib/Email/MIME/CreateHTML.pm
line 203, near "croak "You must supply a body""
(Do you need to predeclare croak?)
t/pod_coverage.t .................... ok
I've attached a patch which adresses the two problems. One was that Carp
was missing inside the package Email::MIME, the other one covers a POD
error (which has already been reported) by correcting the syntax of an
http link.
Regards
Uli
| Subject: | Email-MIME-CreateHTML.patch |
diff -Naur Email-MIME-CreateHTML-1.026/lib/Email/MIME/CreateHTML.pm Email-MIME-CreateHTML-1.026.new/lib/Email/MIME/CreateHTML.pm
--- Email-MIME-CreateHTML-1.026/lib/Email/MIME/CreateHTML.pm 2006-10-26 11:19:04.000000000 +0200
+++ Email-MIME-CreateHTML-1.026.new/lib/Email/MIME/CreateHTML.pm 2009-11-08 20:06:26.000000000 +0100
@@ -195,6 +195,7 @@
use strict;
use Email::MIME::Creator;
+use Carp;
sub create_html {
my ($class, %args) = @_;
@@ -658,7 +659,7 @@
=head1 SEE ALSO
-L<Perl Email Project|http://pep.pobox.com>
+Perl Email Project L<http://pep.pobox.com>
L<Email::Simple>, L<Email::MIME>, L<Email::Send>, L<Email::MIME::Creator>