Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Pod-Simple CPAN distribution.

Report information
The Basics
Id: 51187
Status: resolved
Priority: 0/
Queue: Pod-Simple

People
Owner: Nobody in particular
Requestors: daxim [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 3.09
Fixed in: (no value)



Subject: nested lists not well-formed XHTML
Nesting lists (=over ... =over) emits <dd><dl></dd>...</dl> which is not correctly nested. Test case attached.
Subject: 0001-test-for-nested-lists.patch
From 97cc7e43d6f5b9800dc8fad8141f29cef4a91115 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20D=C9=AA=E1=B4=87=E1=B4=84=E1=B4=8B=E1=B4=8F=E1=B4=A1=20=E8=BF=AA=E6=8B=89=E6=96=AF?= <daxim@cpan.org> Date: Sat, 7 Nov 2009 14:33:09 +0100 Subject: [PATCH] test for nested lists --- t/xhtml01.t | 44 +++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 43 insertions(+), 1 deletions(-) diff --git a/t/xhtml01.t b/t/xhtml01.t index d272390..38c1742 100644 --- a/t/xhtml01.t +++ b/t/xhtml01.t @@ -8,7 +8,7 @@ BEGIN { use strict; use lib '../lib'; -use Test::More tests => 33; +use Test::More tests => 34; use_ok('Pod::Simple::XHTML') or exit; @@ -220,6 +220,48 @@ is($results, <<'EOHTML', "bulleted author list"); EOHTML +initialize($parser, $results); +$parser->parse_string_document(<<'EOPOD'); +=over + +=item Pinky + +=over + +=item World Domination + +=back + +=item Brain + +=back + +EOPOD + +is($results, <<'EOHTML', 'nested lists'); +<dl> + +<dt>Pinky</dt> +<dd> + +</dd> + +<dl> + +<dt>World Domination</dt> +<dd> + +</dd> +</dl> + +<dt>Brain</dt> +<dd> + +</dd> +</dl> + +EOHTML + initialize($parser, $results); $parser->parse_string_document(<<'EOPOD'); -- 1.6.4.1
On Sat Nov 07 08:39:33 2009, DAXIM wrote: Show quoted text
> Nesting lists (=over ... =over) emits <dd><dl></dd>...</dl> which is > not correctly nested. Test case attached.
Thanks for the spot, Lars. You are right that nested definition lists were broken in XHTML output, and I've now fixed it in r407 thanks to your test case (plus another I added). Do note, however, that the nested <dl> goes inside the <dd>, not outside of it as in your example. At least that's the way I understand the spec (example here: http://archivist.incutio.com/viewlist/css-discuss/43568). So I just had to move the nested <dl> into the <dd> and then got the tests passing. Anyway, I expect we'll ship a new version soonish with this fix. Thanks! David