Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Pod-Simple CPAN distribution.

Report information
The Basics
Id: 51184
Status: resolved
Priority: 0/
Queue: Pod-Simple

People
Owner: Nobody in particular
Requestors: cberry [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 3.09
Fixed in: 3.10



Subject: [PATCH] skip some tests that can't work when case is not preserved
The attached patch skips some tests on VMS that can't work if filename case is not preserved, which by default it isn't on VMS. There are some heuristics in Pod::Simple to derive the correct case from package declarations, but for the tests using squaa::Wowo, there is no relevant package declaration.
Subject: vmspodsimple.patch
--- t/search20.t;-0 2007-09-02 01:21:41 -0500 +++ t/search20.t 2009-11-05 11:31:44 -0600 @@ -69,12 +69,16 @@ print $p; { my $names = join "|", sort values %$where2name; -ok $names, "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik"; +skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + $names, + "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik"; } { my $names = join "|", sort keys %$name2where; -ok $names, "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik"; +skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + $names, + "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik"; } ok( ($name2where->{'squaa'} || 'huh???'), '/squaa\.pm$/'); --- t/search22.t;-0 2007-09-02 01:21:41 -0500 +++ t/search22.t 2009-11-05 18:56:38 -0600 @@ -71,13 +71,17 @@ print $p; { print "# won't show any shadows, since we're just looking at the name2where keys\n"; my $names = join "|", sort keys %$name2where; -ok $names, "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik"; +skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + $names, + "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik"; } { print "# but here we'll see shadowing:\n"; my $names = join "|", sort values %$where2name; -ok $names, "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Glunk|hinkhonk::Vliff|hinkhonk::Vliff|perlflif|perlthng|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Vliff|squaa::Vliff|squaa::Wowo|zikzik"; +skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + $names, + "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Glunk|hinkhonk::Vliff|hinkhonk::Vliff|perlflif|perlthng|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Vliff|squaa::Vliff|squaa::Wowo|zikzik"; my %count; for(values %$where2name) { ++$count{$_} }; @@ -103,8 +107,9 @@ ok( ($name2where->{'perlthng'} || 'hu ok( ($name2where->{'squaa::Vliff'} || 'huh???'), '/[^\^]testlib1/' ); # Some sanity: -ok( ($name2where->{'squaa::Wowo'} || 'huh???'), '/testlib2/' ); - +skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + ($name2where->{'squaa::Wowo'} || 'huh???'), + '/testlib2/'; --- t/search25.t;-0 2007-09-02 01:21:41 -0500 +++ t/search25.t 2009-11-05 18:56:38 -0600 @@ -77,12 +77,16 @@ print $p; { my $names = join "|", sort keys %$name2where; -ok $names, "squaa::Glunk|squaa::Vliff|squaa::Wowo"; +skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + $names, + "squaa::Glunk|squaa::Vliff|squaa::Wowo"; } { my $names = join "|", sort values %$where2name; -ok $names, "squaa::Glunk|squaa::Vliff|squaa::Vliff|squaa::Vliff|squaa::Wowo"; +skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + $names, + "squaa::Glunk|squaa::Vliff|squaa::Vliff|squaa::Vliff|squaa::Wowo"; my %count; for(values %$where2name) { ++$count{$_} }; @@ -102,7 +106,9 @@ ok ! $name2where->{'squaa'}; # because ok( ($name2where->{'squaa::Vliff'} || 'huh???'), '/[^\^]testlib1/' ); -ok( ($name2where->{'squaa::Wowo'} || 'huh???'), '/testlib2/' ); +skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + ($name2where->{'squaa::Wowo'} || 'huh???'), + '/testlib2/'; print "# OK, bye from ", __FILE__, "\n"; --- t/search27.t;-0 2007-09-02 01:21:41 -0500 +++ t/search27.t 2009-11-05 19:40:32 -0600 @@ -74,12 +74,16 @@ print $p; { my $names = join "|", sort keys %$name2where; -ok $names, "squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo"; +skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + $names, + "squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo"; } { my $names = join "|", sort values %$where2name; -ok $names, "squaa|squaa::Glunk|squaa::Vliff|squaa::Vliff|squaa::Vliff|squaa::Wowo"; +skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + $names, + "squaa|squaa::Glunk|squaa::Vliff|squaa::Vliff|squaa::Vliff|squaa::Wowo"; my %count; for(values %$where2name) { ++$count{$_} }; @@ -99,7 +103,9 @@ ok $name2where->{'squaa'}; # because ok( ($name2where->{'squaa::Vliff'} || 'huh???'), '/[^\^]testlib1/' ); -ok( ($name2where->{'squaa::Wowo'} || 'huh???'), '/testlib2/' ); +skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + ($name2where->{'squaa::Wowo'} || 'huh???'), + '/testlib2/'; print "# OK, bye from ", __FILE__, "\n"; --- t/search50.t;-0 2007-09-02 01:21:41 -0500 +++ t/search50.t 2009-11-05 19:38:09 -0600 @@ -77,7 +77,10 @@ if( $testmod ) { print "# Comparing \"$x[0]\" to \"$x[1]\"\n"; for(@x) { s{[/\\]}{/}g; } print "# => \"$x[0]\" to \"$x[1]\"\n"; - ok $x[0], $x[1], " find('$testmod') should match survey's name2where{$testmod}"; + skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0, + $x[0], + $x[1], + " find('$testmod') should match survey's name2where{$testmod}"; } else { ok 0; # no 'thatpath/<name>.pm' means can't test find() }
On Fri Nov 06 23:12:41 2009, CBERRY wrote: Show quoted text
> The attached patch skips some tests on VMS that can't work if filename > case is not preserved, > which by default it isn't on VMS. There are some heuristics in > Pod::Simple to derive the correct > case from package declarations, but for the tests using squaa::Wowo, > there is no relevant > package declaration.
Committed, thanks. Allison, this needs to go back downstream to blead. Do you think it merits another release, along with the line ending changes from RT # 50922? I think that Jesse prefers that dual-life modules be the same in blead as in release, so I think a new release is what they'd prefer. David