Skip Menu |

This queue is for tickets about the Data-Peek CPAN distribution.

Report information
The Basics
Id: 51182
Status: resolved
Priority: 0/
Queue: Data-Peek

People
Owner: Nobody in particular
Requestors: taro.nishino [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 0.27
  • 0.28
Fixed in: 0.29



Subject: 20_DPeek.t fix patch
Hi H.Merijn, As you know, Test::NoWarnings must be counted among test counts, so we can't write "skip_all". I understand you might want to ignore when NO_SV_PEEK is 1, in which case maybe Data::Peek is meaningless. I, however, want to use this module nonetheless. May I ask you a favour? Could you apply the attached patch? Best regards, Taro Nishino
Subject: 20_DPeek.t.diff.txt
--- 20_DPeek.t.orig Sat Nov 7 09:59:11 2009 +++ 20_DPeek.t Sat Nov 7 11:17:35 2009 @@ -10,14 +10,12 @@ $| = 1; +SKIP: { my $peek = DPeek (0); if ($peek =~ m/^Your perl did not/) { - plan skip_all => $peek; + skip($peek, 49); } -else { plan tests => 50; - } - like (DPeek ($/), qr'^PVMG\("\\(n|12)"\\0\)', '$/'); is (DPeek ($\), 'PVMG()', '$\\'); is (DPeek ($.), 'PVMG()', '$.'); @@ -73,8 +71,7 @@ SKIP: { $] <= 5.008001 and skip "UTF8 tests useless in this ancient perl version", 1; $VAR = "a\x0a\x{20ac}"; - like (DPeek ($VAR), qr'^PVIV\("a\\(n|12)\\342\\202\\254"\\0\) \[UTF8 "a\\?n\\x{20ac}"\]', - ' $VAR "a\x0a\x{20ac}"'); + like (DPeek ($VAR), qr'^PVIV\("a\\(n|12)\\342\\202\\254"\\0\) \[UTF8 "a\\?n\\x{20ac}"\]', ' $VAR "a\x0a\x{20ac}"'); } $VAR = sub { "VAR" }; is (DPeek ($VAR), '\CV(__ANON__)', ' $VAR sub { "VAR" }'); @@ -92,5 +89,5 @@ is (DPeek (*VAR{IO}), '\IO()', ' *VAR{IO}'); is (DPeek (*VAR{FORMAT}),$]<5.008?'SV_UNDEF':'\FM()',' *VAR{FORMAT}'); } - + } 1;
Subject: Re: [rt.cpan.org #51182] 20_DPeek.t fix patch
Date: Sat, 7 Nov 2009 13:27:18 +0100
To: bug-Data-Peek [...] rt.cpan.org
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
On Fri, 06 Nov 2009 22:42:32 -0500, "Taro Nishino via RT" Show quoted text
> As you know, Test::NoWarnings must be counted among test counts, so we can't > write "skip_all". I understand you might want to ignore when NO_SV_PEEK is 1, in > which case maybe Data::Peek is meaningless. I, however, want to use this module > nonetheless. > May I ask you a favour? Could you apply the attached patch?
Done different, but done. I have no idea what the purpose of the third chunk is. $ wget --output-document=Data-Peek-git.tgz \ 'http://repo.or.cz/w/Data-Peek.git?a=snapshot;sf=tgz' -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
Subject: Re: [rt.cpan.org #51182] 20_DPeek.t fix patch
Date: Sun, 08 Nov 2009 00:02:43 +0900
To: bug-Data-Peek [...] rt.cpan.org
From: Taro Nishino <taro.nishino [...] gmail.com>
On Sat, 07 Nov 2009 07:29:27 -0500 "h.m.brand@xs4all.nl via RT" <bug-Data-Peek@rt.cpan.org> wrote: Show quoted text
> Done different, but done. I have no idea what the purpose of the third > chunk is. > > $ wget --output-document=Data-Peek-git.tgz \ > 'http://repo.or.cz/w/Data-Peek.git?a=snapshot;sf=tgz' >
Thanks a lot. I confirmed 20_DPeek.t's pass as a matter of course. The third chunk of my patch was the closed brace of the first "SKIP:". My bad. Best Regards, Taro Nishino