Bug #51171 for POE: POE::Wheel::Run->kill return value portability

Fri Nov 06 11:25:06 2009 dolmen [...] cpan.org - Ticket created

Subject:

POE::Wheel::Run->kill return value portability

The return value of POE::Wheel::Run->kill() should be portable: same kind of value either Win32 or *n*x. The current code return the return value of CORE::kill() on Unix and Win32::Process::KillProcess on Win32, but those return values have not the same meaning. See TerminateProcess, the Win32 API function used internally by KillProcess() http://msdn.microsoft.com/en-us/library/ms686714%28VS.85%29.aspx -- Olivier Mengué - http://o.mengue.free.fr/

Fri Nov 06 11:28:08 2009 dolmen [...] cpan.org - Correspondence added

Subject:

[FIX] POE::Wheel::Run->kill return value portability

Le Ven. Nov. 06 11:25:06 2009, DOLMEN a écrit : Show quoted text

> The return value of POE::Wheel::Run->kill() should be portable: same > kind of value either Win32 or *n*x.

The return value of CORE::kill() is the count of signaled process. So it is either 0 or 1. So the fix is to return the same errors on Win32: Win32::Process::KillProcess( $self->[MSWIN32_GROUP_PID], 293 ) ? 1 : 0; Also the return value should be documented. -- Olivier Mengué - http://o.mengue.free.fr/

Fri Nov 06 11:28:12 2009 dolmen [...] cpan.org - Status changed from 'new' to 'open'

Mon Dec 28 22:23:09 2009 RCAPUTO [...] cpan.org - Correspondence added

Thank you for pointing this out. I've committed your fix as revision 2766.

Mon Dec 28 22:23:10 2009 RCAPUTO [...] cpan.org - Status changed from 'open' to 'resolved'