Skip Menu |

This queue is for tickets about the Object-Event CPAN distribution.

Report information
The Basics
Id: 51127
Status: resolved
Priority: 0/
Queue: Object-Event

People
Owner: Nobody in particular
Requestors: stephane [...] shimaore.net
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 1.2
Fixed in: 1.21



Subject: recursion through exception callback / Undefined subroutine &main::
Hello, Found this while testing today. Error messages when calling callbacks: recursion through exception callback (debug_recv AnyEvent::XMPP::IM::Connection=HASH(0x2038140) <proceed xmlns='urn:ietf:params:xml:ns:xmpp-tls'/>) => (error, AnyEvent::XMPP::IM::Connection=HASH(0x2038140), AnyEvent::XMPP::Error::Exception=HASH(0x2203848)): Undefined subroutine &main:: called at /usr/local/share/perl/5.10.0/Object/Event.pm line 435. The issue was introduced in 1.2. Fix is: Change line 435 in Object/Event.pm from: $cbs[0]->[4]->($self, @arg), shift @cbs while @cbs; back to: $cbs[0]->[2]->($self, @arg), shift @cbs while @cbs;
Actually the fix I offered doesn't seem to work. $cbs->[0]->[4] is undef (the array is one 3 long), and $cbs[0]->[2] is a CODE object, but this still doesn't work.
Subject: Re: [rt.cpan.org #51127] recursion through exception callback / Undefined subroutine &main::
Date: Thu, 5 Nov 2009 15:07:59 +0100
To: Stéphane Alnet via RT <bug-Object-Event [...] rt.cpan.org>
From: Robin Redeker <elmex [...] ta-sa.org>
Hi! On Thu, Nov 05, 2009 at 07:59:48AM -0500, Stéphane Alnet via RT wrote: Show quoted text
> Queue: Object-Event > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=51127 > > > Actually the fix I offered doesn't seem to work. $cbs->[0]->[4] is undef > (the array is one 3 long), and $cbs[0]->[2] is a CODE object, but this > still doesn't work.
Yes, I think it has to do with the old forward code, It probably adds a callback structure with the wrong 'layout'. I'll look into a fix for this in some hours. Thanks for this report! Greetings, Robin -- Robin Redeker | Deliantra, the free code+content MORPG elmex@ta-sa.org / r.redeker@gmail.com | http://www.deliantra.net http://www.ta-sa.org/ |
Subject: Re: [rt.cpan.org #51127] recursion through exception callback / Undefined subroutine &main::
Date: Thu, 5 Nov 2009 15:27:52 +0100
To: Stéphane Alnet via RT <bug-Object-Event [...] rt.cpan.org>
From: Robin Redeker <elmex [...] ta-sa.org>
Hi again! I've probably found the bug, could you try the git version of Object::Event: git clone http://git.ta-sa.org/Object-Event.git The commit that hopefully fixed is was: http://git.ta-sa.org/git/Object-Event/commit/?id=8a23a61677a3af5f2e87a4aed9dc0eb481235e71 Thanks! Robin On Thu, Nov 05, 2009 at 07:59:48AM -0500, Stéphane Alnet via RT wrote: Show quoted text
> Queue: Object-Event > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=51127 > > > Actually the fix I offered doesn't seem to work. $cbs->[0]->[4] is undef > (the array is one 3 long), and $cbs[0]->[2] is a CODE object, but this > still doesn't work.
-- Robin Redeker | Deliantra, the free code+content MORPG elmex@ta-sa.org / r.redeker@gmail.com | http://www.deliantra.net http://www.ta-sa.org/ |
Hello Robin, Show quoted text
> I've probably found the bug, could you try the git version of > Object::Event: > git clone http://git.ta-sa.org/Object-Event.git
This works fine, thank you so much for the quick fix! Stéphane
Subject: Re: [rt.cpan.org #51127] recursion through exception callback / Undefined subroutine &main::
Date: Thu, 5 Nov 2009 17:27:45 +0100
To: Stéphane Alnet via RT <bug-Object-Event [...] rt.cpan.org>
From: Robin Redeker <elmex [...] ta-sa.org>
Hi Stéphane! On Thu, Nov 05, 2009 at 09:44:40AM -0500, Stéphane Alnet via RT wrote: Show quoted text
> Queue: Object-Event > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=51127 > > > Hello Robin, >
> > I've probably found the bug, could you try the git version of > > Object::Event: > > git clone http://git.ta-sa.org/Object-Event.git
> > This works fine, thank you so much for the quick fix!
Glad it works. I'll release the fix this evening :) Have fun! Robin -- Robin Redeker | Deliantra, the free code+content MORPG elmex@ta-sa.org / r.redeker@gmail.com | http://www.deliantra.net http://www.ta-sa.org/ |