Skip Menu |

This queue is for tickets about the Mozilla-DOM CPAN distribution.

Report information
The Basics
Id: 51011
Status: open
Priority: 0/
Queue: Mozilla-DOM

People
Owner: Nobody in particular
Requestors: kashiwa [...] liarsoft.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.22
Fixed in: (no value)



Subject: firefox 3.5 compatibility patch
I made new namespace 'Mozilla::DOM::NSElement' because some properties (scroll*/client*) in nsIDOMNSHTMLElement are moved into nsIDOMNSElement in mozilla 1.9.1.
Subject: for_moz1_9_1.patch
diff -ur .cpan/build/Mozilla-DOM-0.22-NsjSHA/doctypes .cpan/build/Mozilla-DOM-0.22-OUMHYt/doctypes --- .cpan/build/Mozilla-DOM-0.22-NsjSHA/doctypes 2007-04-08 06:32:27.000000000 +0900 +++ .cpan/build/Mozilla-DOM-0.22-OUMHYt/doctypes 2009-11-01 00:26:45.000000000 +0900 @@ -34,6 +34,7 @@ nsIDOMNodeList Mozilla::DOM::NodeList nsIDOMNamedNodeMap Mozilla::DOM::NamedNodeMap nsIDOMElement Mozilla::DOM::Element +nsIDOMNSElement Mozilla::DOM::NSElement nsIDOMEntity Mozilla::DOM::Entity nsIDOMEntityReference Mozilla::DOM::EntityReference nsIDOMAttr Mozilla::DOM::Attr diff -ur .cpan/build/Mozilla-DOM-0.22-NsjSHA/mozilladom.typemap .cpan/build/Mozilla-DOM-0.22-OUMHYt/mozilladom.typemap --- .cpan/build/Mozilla-DOM-0.22-NsjSHA/mozilladom.typemap 2007-04-08 06:32:27.000000000 +0900 +++ .cpan/build/Mozilla-DOM-0.22-OUMHYt/mozilladom.typemap 2009-10-31 06:37:58.000000000 +0900 @@ -31,6 +31,7 @@ nsIDOMNodeList * T_MOZDOM_GENERIC_WRAPPER nsIDOMNamedNodeMap * T_MOZDOM_GENERIC_WRAPPER nsIDOMElement * T_MOZDOM_GENERIC_WRAPPER +nsIDOMNSElement * T_MOZDOM_GENERIC_WRAPPER nsIDOMEntity * T_MOZDOM_GENERIC_WRAPPER nsIDOMEntityReference * T_MOZDOM_GENERIC_WRAPPER nsIDOMAttr * T_MOZDOM_GENERIC_WRAPPER diff -ur .cpan/build/Mozilla-DOM-0.22-NsjSHA/mozilladom2perl.h .cpan/build/Mozilla-DOM-0.22-OUMHYt/mozilladom2perl.h --- .cpan/build/Mozilla-DOM-0.22-NsjSHA/mozilladom2perl.h 2007-06-07 06:46:36.000000000 +0900 +++ .cpan/build/Mozilla-DOM-0.22-OUMHYt/mozilladom2perl.h 2009-11-01 05:12:33.000000000 +0900 @@ -77,6 +77,7 @@ #include "nsIDOMDocumentType.h" #include "nsIDOMDocumentView.h" #include "nsIDOMElement.h" +#include "nsIDOMNSElement.h" #include "nsIDOMEntity.h" #include "nsIDOMEntityReference.h" #include "nsIDOMNSEvent.h" @@ -235,6 +236,7 @@ MOZDOM_DECL_DOM_TYPEMAPPERS(NodeList) MOZDOM_DECL_DOM_TYPEMAPPERS(NamedNodeMap) MOZDOM_DECL_DOM_TYPEMAPPERS(Element) +MOZDOM_DECL_DOM_TYPEMAPPERS(NSElement) MOZDOM_DECL_DOM_TYPEMAPPERS(Entity) MOZDOM_DECL_DOM_TYPEMAPPERS(EntityReference) MOZDOM_DECL_DOM_TYPEMAPPERS(Attr) diff -ur .cpan/build/Mozilla-DOM-0.22-NsjSHA/xs/DOM.xs .cpan/build/Mozilla-DOM-0.22-OUMHYt/xs/DOM.xs --- .cpan/build/Mozilla-DOM-0.22-NsjSHA/xs/DOM.xs 2009-10-10 06:34:46.000000000 +0900 +++ .cpan/build/Mozilla-DOM-0.22-OUMHYt/xs/DOM.xs 2009-11-01 05:04:39.000000000 +0900 @@ -56,6 +56,7 @@ MOZDOM_DEF_DOM_TYPEMAPPERS(NodeList) MOZDOM_DEF_DOM_TYPEMAPPERS(NamedNodeMap) MOZDOM_DEF_DOM_TYPEMAPPERS(Element) +MOZDOM_DEF_DOM_TYPEMAPPERS(NSElement) MOZDOM_DEF_DOM_TYPEMAPPERS(Entity) MOZDOM_DEF_DOM_TYPEMAPPERS(EntityReference) MOZDOM_DEF_DOM_TYPEMAPPERS(Attr) @@ -4443,6 +4444,8 @@ RETVAL = newSVnsIDOMDocumentView((nsIDOMDocumentView *)res); } else if (uuid.Equals(nsIDOMElement::GetIID())) { RETVAL = newSVnsIDOMElement((nsIDOMElement *)res); + } else if (uuid.Equals(nsIDOMNSElement::GetIID())) { + RETVAL = newSVnsIDOMNSElement((nsIDOMNSElement *)res); } else if (uuid.Equals(nsIDOMEntity::GetIID())) { RETVAL = newSVnsIDOMEntity((nsIDOMEntity *)res); } else if (uuid.Equals(nsIDOMEntityReference::GetIID())) { @@ -6671,102 +6674,117 @@ CODE: nshtmlelement->SetInnerHTML(aInnerHTML); +## ScrollIntoView(PRBool top) +void +moz_dom_ScrollIntoView (nshtmlelement, top) + nsIDOMNSHTMLElement *nshtmlelement; + PRBool top; + CODE: + nshtmlelement->ScrollIntoView(top); + +# ----------------------------------------------------------------------------- + +MODULE = Mozilla::DOM PACKAGE = Mozilla::DOM::NSElement PREFIX = moz_dom_ + +# /usr/include/mozilla/dom/nsIDOMNSElement.h + +## NS_DEFINE_STATIC_IID_ACCESSOR(NS_IDOMNSELEMENT_IID) +static nsIID +nsIDOMNSElement::GetIID() + CODE: + const nsIID &id = nsIDOMNSElement::GetIID(); + RETVAL = (nsIID) id; + OUTPUT: + RETVAL + ## GetScrollTop(PRInt32 *aScrollTop) PRInt32 -moz_dom_GetScrollTop (nshtmlelement) - nsIDOMNSHTMLElement *nshtmlelement; +moz_dom_GetScrollTop (nselement) + nsIDOMNSElement *nselement; PREINIT: PRInt32 aScrollTop; CODE: - nshtmlelement->GetScrollTop(&aScrollTop); + nselement->GetScrollTop(&aScrollTop); RETVAL = aScrollTop; OUTPUT: RETVAL ## SetScrollTop(PRInt32 aScrollTop) void -moz_dom_SetScrollTop (nshtmlelement, aScrollTop) - nsIDOMNSHTMLElement *nshtmlelement; +moz_dom_SetScrollTop (nselement, aScrollTop) + nsIDOMNSElement *nselement; PRInt32 aScrollTop; CODE: - nshtmlelement->SetScrollTop(aScrollTop); + nselement->SetScrollTop(aScrollTop); ## GetScrollLeft(PRInt32 *aScrollLeft) PRInt32 -moz_dom_GetScrollLeft (nshtmlelement) - nsIDOMNSHTMLElement *nshtmlelement; +moz_dom_GetScrollLeft (nselement) + nsIDOMNSElement *nselement; PREINIT: PRInt32 aScrollLeft; CODE: - nshtmlelement->GetScrollLeft(&aScrollLeft); + nselement->GetScrollLeft(&aScrollLeft); RETVAL = aScrollLeft; OUTPUT: RETVAL ## SetScrollLeft(PRInt32 aScrollLeft) void -moz_dom_SetScrollLeft (nshtmlelement, aScrollLeft) - nsIDOMNSHTMLElement *nshtmlelement; +moz_dom_SetScrollLeft (nselement, aScrollLeft) + nsIDOMNSElement *nselement; PRInt32 aScrollLeft; CODE: - nshtmlelement->SetScrollLeft(aScrollLeft); + nselement->SetScrollLeft(aScrollLeft); ## GetScrollHeight(PRInt32 *aScrollHeight) PRInt32 -moz_dom_GetScrollHeight (nshtmlelement) - nsIDOMNSHTMLElement *nshtmlelement; +moz_dom_GetScrollHeight (nselement) + nsIDOMNSElement *nselement; PREINIT: PRInt32 aScrollHeight; CODE: - nshtmlelement->GetScrollHeight(&aScrollHeight); + nselement->GetScrollHeight(&aScrollHeight); RETVAL = aScrollHeight; OUTPUT: RETVAL ## GetScrollWidth(PRInt32 *aScrollWidth) PRInt32 -moz_dom_GetScrollWidth (nshtmlelement) - nsIDOMNSHTMLElement *nshtmlelement; +moz_dom_GetScrollWidth (nselement) + nsIDOMNSElement *nselement; PREINIT: PRInt32 aScrollWidth; CODE: - nshtmlelement->GetScrollWidth(&aScrollWidth); + nselement->GetScrollWidth(&aScrollWidth); RETVAL = aScrollWidth; OUTPUT: RETVAL ## GetClientHeight(PRInt32 *aClientHeight) PRInt32 -moz_dom_GetClientHeight (nshtmlelement) - nsIDOMNSHTMLElement *nshtmlelement; +moz_dom_GetClientHeight (nselement) + nsIDOMNSElement *nselement; PREINIT: PRInt32 aClientHeight; CODE: - nshtmlelement->GetClientHeight(&aClientHeight); + nselement->GetClientHeight(&aClientHeight); RETVAL = aClientHeight; OUTPUT: RETVAL ## GetClientWidth(PRInt32 *aClientWidth) PRInt32 -moz_dom_GetClientWidth (nshtmlelement) - nsIDOMNSHTMLElement *nshtmlelement; +moz_dom_GetClientWidth (nselement) + nsIDOMNSElement *nselement; PREINIT: PRInt32 aClientWidth; CODE: - nshtmlelement->GetClientWidth(&aClientWidth); + nselement->GetClientWidth(&aClientWidth); RETVAL = aClientWidth; OUTPUT: RETVAL -## ScrollIntoView(PRBool top) -void -moz_dom_ScrollIntoView (nshtmlelement, top) - nsIDOMNSHTMLElement *nshtmlelement; - PRBool top; - CODE: - nshtmlelement->ScrollIntoView(top); - # ----------------------------------------------------------------------------- MODULE = Mozilla::DOM PACKAGE = Mozilla::DOM::HTMLEmbedElement PREFIX = moz_dom_
On Sat Oct 31 17:28:45 2009, http://www.hatena.ne.jp/kash1wa/ wrote: Show quoted text
> I made new namespace 'Mozilla::DOM::NSElement' because some properties > (scroll*/client*) in nsIDOMNSHTMLElement are moved into nsIDOMNSElement > in mozilla 1.9.1.
I used patch -p3 < patchfile.patch to apply this. At first I thought it didn't apply, then I noticed -p1 wasn't enough. Any hope of getting this applied to a 0.24 release? ubuntu 10.04 comes with xulrunner 1.9.2, so the HTML Elements just don't have GetScrollTop (et al) anymore. -- If riding in an airplane is flying, then riding in a boat is swimming. 114 jumps, 47.2 minutes of freefall, 90.4 freefall miles.
On Wed Jun 16 10:12:11 2010, JETTERO wrote: Show quoted text
> Any hope of getting this applied to a 0.24 release? ubuntu 10.04 comes > with xulrunner 1.9.2, so the HTML Elements just don't have GetScrollTop > (et al) anymore.
Ok, sorry I didn't see this bug report before.