Skip Menu |

This queue is for tickets about the Alien-wxWidgets CPAN distribution.

Report information
The Basics
Id: 50944
Status: resolved
Priority: 0/
Queue: Alien-wxWidgets

People
Owner: Nobody in particular
Requestors: daxim [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.45
Fixed in: (no value)



Subject: always downloads Wx
Build.PL asks a question, defaulting to the string 'no'. my $build_wx = _askyn(... Later: if( $build_wx ) { ... The expression will always be true, hence Build will always attempt to download Wx instead of using the system-supplied installation. Attached fixes this (in a crude way). It applies against 0.45 with the command git apply *.patch
Subject: 0002-no-means-no-except-in-bool-context.patch
From 79af5b68d69253e0717c21e3b8833d08a97abf49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20D=C9=AA=E1=B4=87=E1=B4=84=E1=B4=8B=E1=B4=8F=E1=B4=A1=20=E8=BF=AA=E6=8B=89=E6=96=AF?= <daxim@cpan.org> Date: Thu, 29 Oct 2009 14:48:32 +0100 Subject: [PATCH 2/2] no means no except in bool context --- Build.PL | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Build.PL b/Build.PL index f4f2b98..4bbb503 100644 --- a/Build.PL +++ b/Build.PL @@ -99,6 +99,7 @@ EOT chomp $build_prompt; my $build_wx = _askyn( $build, 'wxWidgets-build', $build_prompt, $build_wx_dflt ); +undef $build_wx if 'no' eq $build_wx; $build->notes( 'build_wx' => $build_wx ); $build->notes( 'mk_portable' => $build->args('wxWidgets-portable') ); if( $build_wx ) { -- 1.6.4
Subject: Re: [rt.cpan.org #50944] always downloads Wx
Date: Sun, 01 Nov 2009 16:03:09 +0100
To: bug-Alien-wxWidgets [...] rt.cpan.org
From: Mattia Barbon <mattia.barbon [...] libero.it>
Lars Dɪᴇᴄᴋᴏᴡ 迪拉斯 via RT wrote: Show quoted text
> Build.PL asks a question, defaulting to the string 'no'. > > my $build_wx = _askyn(... > > Later: > > if( $build_wx ) { ... > > The expression will always be true, hence Build will always attempt to > download Wx instead of using the system-supplied installation.
I fixed it directly in the _askyn sub. Thanks! Mattia