Skip Menu |

This queue is for tickets about the Compress-Raw-Bzip2 CPAN distribution.

Report information
The Basics
Id: 50925
Status: resolved
Priority: 0/
Queue: Compress-Raw-Bzip2

People
Owner: Nobody in particular
Requestors: shay [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.021
Fixed in: 2.023



Subject: Convert Compress-Raw-Bzip2 source file from DOS EOLs to UNIX EOLs
A recent discussion on p5p: http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2009-10/msg00967.html lead to a change being made to the release process so that certain files (mainly under win32/) that used to be converted from UNIX EOLs (in the repository) to DOS EOLs (in the release tarball) are no longer converted. The reason was simply that it is no longer necessary for these files to have DOS EOLs, since modern Windows programs cope perfectly well with UNIX EOLs, and it is simpler not to do the conversion. It was noticed at the same time that a small number of other files currently have DOS EOLs in the repository, and it would perhaps be simpler if all files in the repository had UNIX EOLs (unless any have to have DOS EOLs for some reason). The file bzip2-src/dlltest.c in Compress-Raw-Bzip2 has DOS EOLs. It would be helpful if a new release of Compress-Raw-Bzip2 could be made which converts this file to UNIX EOLs, and it would be best for people in the future looking back through the history of changes to files if nothing else was changed in this file at the same time (otherwise those other changes would get masked somewhat by the noise of the EOLs changes).
On Wed Oct 28 13:33:35 2009, SHAY wrote: Show quoted text
> A recent discussion on p5p: > >
http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2009-10/msg00967.html Show quoted text
> > lead to a change being made to the release process so that certain files > (mainly under win32/) that used to be converted from UNIX EOLs (in the > repository) to DOS EOLs (in the release tarball) are no longer > converted. The reason was simply that it is no longer necessary for > these files to have DOS EOLs, since modern Windows programs cope > perfectly well with UNIX EOLs, and it is simpler not to do the conversion. > > It was noticed at the same time that a small number of other files > currently have DOS EOLs in the repository, and it would perhaps be > simpler if all files in the repository had UNIX EOLs (unless any have to > have DOS EOLs for some reason). > > The file bzip2-src/dlltest.c in Compress-Raw-Bzip2 has DOS EOLs. It > would be helpful if a new release of Compress-Raw-Bzip2 could be made > which converts this file to UNIX EOLs, and it would be best for people > in the future looking back through the history of changes to files if > nothing else was changed in this file at the same time (otherwise those > other changes would get masked somewhat by the noise of the EOLs changes).
Hi Steve - the file in question is one of the bzip2 source files I copied directly from the bzip2 sources. I usually try not to mess with them unless absolutely necessary. In this case though I can actually delete the file - it is not used by my module. Paul