Bug #50911 for Text-CSV_XS: Quoting of strings containing space character

Wed Oct 28 07:20:37 2009 YKAR [...] cpan.org - Ticket created

Subject:

Quoting of strings containing space character

Currently CSV entry is quoted if it contain space character. It would be nice to quote value only if it contains either leading or trailing spaces. I guess unquoted CSV entry with inner spaces is correct and can be parsed unambiguously. RATIONALE: - Generated CSV can be smaller on some datasets - Some broken programs does not support CSV quoting. If module quote strings only if really needed, generated output can be fed into such broken programs.

Mon Nov 30 10:12:27 2009 HMBRAND [...] cpan.org - Severity Wishlist added

Mon Nov 30 10:12:27 2009 HMBRAND [...] cpan.org - Broken in 0.23 added

Mon Nov 30 10:12:27 2009 HMBRAND [...] cpan.org - Status changed from 'new' to 'open'

Mon Nov 30 11:26:59 2009 HMBRAND [...] cpan.org - Status changed from 'open' to 'patched'

Sun Dec 13 07:10:30 2009 YKAR [...] cpan.org - Correspondence added

Thank you for taking into account my suggestion. quote_space, works not very well. If string has any leading or trailing spaces, they will be lost, because CSV parser strip any white space from the beginning and from the end of the string. So it is safe not to quote string only if string does not have leading or trailing spaces.

Sun Dec 13 07:10:31 2009 The RT System itself - Status changed from 'patched' to 'open'

Sun Dec 13 07:43:09 2009 h.m.brand [...] xs4all.nl - Correspondence added

Subject:	Re: [rt.cpan.org #50911] Quoting of strings containing space character
Date:	Sun, 13 Dec 2009 13:30:22 +0100
To:	bug-Text-CSV_XS [...] rt.cpan.org
From:	"H.Merijn Brand" <h.m.brand [...] xs4all.nl>

On Sun, 13 Dec 2009 07:10:31 -0500, "YKAR via RT" <bug-Text-CSV_XS@rt.cpan.org> wrote: Show quoted text

> Queue: Text-CSV_XS > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=50911 > > > Thank you for taking into account my suggestion. > > quote_space, works not very well. If string has any leading or trailing > spaces, they will be lost, because CSV parser strip any white space from > the beginning and from the end of the string. So it is safe not to quote > string only if string does not have leading or trailing spaces.

$ perl -MText::CSV_XS -wle'Text::CSV_XS->new({quote_space=>0})->print(*STDOUT,["x"," x","x ","x x"," x x ",1])' x, x,x ,x x, x x ,1 $ perl -MText::CSV_XS -wle'Text::CSV_XS->new({quote_space=>1})->print(*STDOUT,["x"," x","x ","x x"," x x ",1])' x," x","x ","x x"," x x ",1 Works exactly as documented IMHO. If leading or trailing spaces are lost by the parser, blame the parser, not the generator -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/

Sun Dec 13 07:59:43 2009 HMBRAND [...] cpan.org - Fixed in 0.70 added

Sun Dec 13 07:59:43 2009 HMBRAND [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Dec 14 09:08:57 2009 YKAR [...] cpan.org - Correspondence added

You right. I just noticed this in RFC 4180 (2.4), parser should not ignore spaces. I'm sorry for bothering you for nothing. And thank you again for implementing the feature. Show quoted text

> If leading or trailing spaces are lost by the parser, blame the > parser, > not the generator

Mon Dec 14 09:08:58 2009 The RT System itself - Status changed from 'resolved' to 'open'

Mon Dec 14 09:09:43 2009 YKAR [...] cpan.org - Status changed from 'open' to 'resolved'