Bug #50883 for Net-DNS: PPP interface nameserver not used on cygwin

Tue Oct 27 11:14:02 2009 mikie [...] iki.fi - Ticket created

Tue Oct 27 11:16:16 2009 mikie [...] iki.fi - Severity Important added

Tue Oct 27 11:16:16 2009 mikie [...] iki.fi - Broken in 0.65 added

Tue Oct 27 11:24:00 2009 mikie [...] iki.fi - Correspondence added

This is basically #11931 but for cygwin. IMO we should just use the same codepath for cygwin as for Win32 in both Makefile.PL and in Resolver.pm as the dependencies (Win32::IPHelper) are available for cygwin too. Attached a patch that does that.

diff -ru Net-DNS-0.65-orig/Makefile.PL Net-DNS-0.65/Makefile.PL --- Net-DNS-0.65-orig/Makefile.PL 2009-01-26 19:31:43.000000000 +0200 +++ Net-DNS-0.65/Makefile.PL 2009-10-27 17:19:40.096000000 +0200 @@ -89,7 +89,7 @@ -if ($^O eq 'MSWin32') { +if ($^O eq 'MSWin32' || $^O eq 'cygwin') { unless( eval {require WIN32::API; } ){ warn <<AMEN; I can not find WIN32::API version 0.55 or higher. Only in Net-DNS-0.65-orig/lib/Net/DNS/Resolver: Cygwin.pm diff -ru Net-DNS-0.65-orig/lib/Net/DNS/Resolver.pm Net-DNS-0.65/lib/Net/DNS/Resolver.pm --- Net-DNS-0.65-orig/lib/Net/DNS/Resolver.pm 2009-01-26 19:31:42.000000000 +0200 +++ Net-DNS-0.65/lib/Net/DNS/Resolver.pm 2009-10-27 16:42:19.952000000 +0200 @@ -13,8 +13,8 @@ require Net::DNS::Resolver::Win32; @ISA = qw(Net::DNS::Resolver::Win32); } elsif ($^O eq 'cygwin') { - require Net::DNS::Resolver::Cygwin; - @ISA = qw(Net::DNS::Resolver::Cygwin); + require Net::DNS::Resolver::Win32; + @ISA = qw(Net::DNS::Resolver::Win32); } else { require Net::DNS::Resolver::UNIX; @ISA = qw(Net::DNS::Resolver::UNIX);

Tue Oct 27 11:24:02 2009 mikie [...] iki.fi - Status changed from 'new' to 'open'

Wed Dec 23 10:30:20 2009 OLAF [...] cpan.org - Correspondence added

Patch applied. I have no good ways of testing this.

Wed Dec 23 10:30:21 2009 OLAF [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Oct 25 08:23:35 2011 willem [...] cpan.org - Status changed from 'resolved' to 'open'

Tue Oct 25 08:36:58 2011 willem [...] cpan.org - Correspondence added

Hi Mikaraento, I reversed this patch, because the cygwin maintainer for perl, Reini, prefers not to use Win32::API and Win32::IPHelper. Also I believe it is better to have less dependencies. How are the nameservers for PPP interfaces registered in the registry? Perhaps Reini's patch already solved your issue; it adds DhcpNameServer entries to the nameservers list. Are you using ppp from cygwin or another ppp? -- Willem

Thu Oct 27 08:54:17 2011 willem [...] cpan.org - Correspondence added

Hi Mikaraento, I have modified it so that the usage of Win32::IPHelper (and thus the Win32.pm codepath for Net::DNS::Resolver) may be chosen for Cygwin during build time. Default it checks if a version of Net::DNS is already installed and copies the setting from that. If installed freshly, the Cygwin codepath is chosen. I feel this is safest as it introduces the least possible chances for people already running Net::DNS. Closing ticket,

Thu Oct 27 08:54:17 2011 willem [...] cpan.org - Status changed from 'open' to 'resolved'