Bug #50830 for Bryar: t/flatfile.t phoning home?!?

Mon Oct 26 07:20:22 2009 polettix [...] cpan.org - Ticket created

Subject:

t/flatfile.t phoning home?!?

Hi, I have no "mail" installed in my system, and I hit the following error while "make test"-ing: PERL_DL_NONLAZY=1 /opt/perl-5.10.1/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/3.t .......... ok t/5.t .......... ok t/cgi.t ........ ok t/collector.t .. ok t/config.t ..... 1/? # Bryar::Collector # 20 t/config.t ..... ok t/flatfile.t ... 1/? sh: mail: command not found Comment failure: Cannot send mail: at /home/poletti/src/Bryar- 4.0/blib/lib/Bryar/DataSource/FlatFile.pm line 244 # Looks like your test exited with 127 just after 10. t/flatfile.t ... Dubious, test returned 127 (wstat 32512, 0x7f00) All 10 subtests passed t/renderer.t ... ok Test Summary Report ------------------- t/flatfile.t (Wstat: 32512 Tests: 10 Failed: 0) Non-zero exit status: 127 Parse errors: No plan found in TAP output Files=7, Tests=53, 3 wallclock secs ( 0.12 usr 0.02 sys + 2.26 cusr 0.14 csys = 2.54 CPU) Result: FAIL Failed 1/7 test programs. 0/53 subtests failed. make: *** [test_dynamic] Error 255 I had to comment out two tests to make the overall testing. This seems to be a leftover from the previous maintainer (the address is David's). Regards, Flavio. More details on the system: This is perl, v5.10.1 (*) built for i686-linux (self compiled) Linux 2.6.27.10-grsec-xxxx-grs-ipv4-32 i686 GNU/Linux (Debian)

Tue Oct 27 13:34:31 2009 dcantrell [...] cpan.org - Correspondence added

On Mon Oct 26 07:20:22 2009, POLETTIX wrote: Show quoted text

> Hi, > > I have no "mail" installed in my system, and I hit the following > error while "make test"-ing: > > PERL_DL_NONLAZY=1 /opt/perl-5.10.1/bin/perl "-MExtUtils::Command::MM" > "-e" > "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > t/3.t .......... ok > t/5.t .......... ok > t/cgi.t ........ ok > t/collector.t .. ok > t/config.t ..... 1/? # Bryar::Collector > # 20 > t/config.t ..... ok > t/flatfile.t ... 1/? sh: mail: command not found > Comment failure: Cannot send mail: at /home/poletti/src/Bryar- > 4.0/blib/lib/Bryar/DataSource/FlatFile.pm line 244 > # Looks like your test exited with 127 just after 10. > t/flatfile.t ... Dubious, test returned 127 (wstat 32512, 0x7f00) > All 10 subtests passed > t/renderer.t ... ok > > Test Summary Report > ------------------- > t/flatfile.t (Wstat: 32512 Tests: 10 Failed: 0) > Non-zero exit status: 127 > Parse errors: No plan found in TAP output > Files=7, Tests=53, 3 wallclock secs ( 0.12 usr 0.02 sys + 2.26 cusr > 0.14 csys = 2.54 CPU) > Result: FAIL > Failed 1/7 test programs. 0/53 subtests failed. > make: *** [test_dynamic] Error 255 > > I had to comment out two tests to make the overall testing. This seems > to be a leftover from > the previous maintainer (the address is David's).

The address used in t/flatfile.t is indeed mine, but that's the address of the person who is leaving a comment in the blog. The mail gets sent to an address @example.com, which is guaranteed to not exist - example.com is reserved for use in examples. As for it not working when 'mail' doesn't exist - I had a fix for that, which I never got round to releasing and so Marco doesn't have it. At the top of add_comment ... my $mailer = (grep { -x } map { $_.'/mail' } split(/:/, $ENV{PATH}))[0]; and when it does the open and pipe later, check that $mailer is true.

Tue Oct 27 13:34:31 2009 The RT System itself - Status changed from 'new' to 'open'

Wed Oct 28 10:48:26 2009 daxim [...] cpan.org - Correspondence added

It's very uncool that the test attempts to leak out my environ(5) onto the Internet. example.com *did* have a stub SMTP server running at one time. Despite its reserved role, it is an existing domain with a live host and should be treated as such! I had to clear out the test's mess from the delay queue. Couldn't you have picked an address like invalid@example.invalid that results in immediate delivery failure (its TLD will never resolve, RFC2606), or even make that test run local only in the first place?