| Subject: | no_match warnings with Googlebot-Mobile/2.1 |
Hi
I found a lot of following warnings our service:
DoCoMo/2.0 N905i(c100;TB;W24H16) (compatible; Googlebot-Mobile/2.1;
+http://www.google.com/bot.html): no match. Might be new variants. please
contact the author of HTTP::MobileAgent
Then I wrote a patch to shut up them. Could you check an attached patch
and merge it to trunk if it would make sense.
Regards,
Hiroshi Sakai
| Subject: | support-newer-googlebot-for-docomo.patch |
Index: t/02_docomo.t
===================================================================
--- t/02_docomo.t (revision 35658)
+++ t/02_docomo.t (working copy)
@@ -1,5 +1,5 @@
use strict;
-use Test::More tests => 936;
+use Test::More tests => 951;
BEGIN { use_ok 'HTTP::MobileAgent' }
@@ -39,6 +39,7 @@
[ "DoCoMo/1.0/SH505i2/c20/TB/W20H10", '1.0', '5.0', 'SH505i', 20, undef, 'SH', '505i', { status => 'TB' }, 0 ],
[ "DoCoMo/1.0/F661i/c10/TB", '1.0', '4.0', 'F661i', 10, undef, 'F', '661i', { is_gps => 1 }, 0 ],
[ "DoCoMo/2.0 P07A3(c500;TB;W24H15)", '2.0', undef, 'P07A3', 500, 1, 'P', 'FOMA', { is_gps => 1, browser_version => '2.0' }, 1 ],
+ [ "DoCoMo/2.0 N905i(c100;TB;W24H16) (compatible; Googlebot-Mobile/2.1; +http://www.google.com/bot.html)", '2.0', '7.1', 'N905i', 100, 1, 'N', 'FOMA', {}, 1 ],
);
for (@Tests) {
Index: lib/HTTP/MobileAgent/DoCoMo.pm
===================================================================
--- lib/HTTP/MobileAgent/DoCoMo.pm (revision 35658)
+++ lib/HTTP/MobileAgent/DoCoMo.pm (working copy)
@@ -94,7 +94,7 @@
$self->{model} = $1;
$self->{model} = 'SH2101V' if $1 eq 'MST_v_SH2101V'; # Huh?
- if ($foma =~ s/^\((.*?)\)$//) {
+ if ($foma =~ s/^\((.*?)\)//) {
my @options = split /;/, $1;
for (@options) {
/^c(\d+)$/ and $self->{cache_size} = $1, next;