Skip Menu |

This queue is for tickets about the Net-LDAP-FilterBuilder CPAN distribution.

Report information
The Basics
Id: 50660
Status: resolved
Priority: 0/
Queue: Net-LDAP-FilterBuilder

People
Owner: OLIVER [...] cpan.org
Requestors: tom.jones [...] oucs.ox.ac.uk
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: as_str part of public interface for Net::LDAP::FilterBuilder?
Date: Mon, 19 Oct 2009 17:45:49 +0100
To: oliver.gorwits [...] oucs.ox.ac.uk
From: Tom Jones <tom.jones [...] oucs.ox.ac.uk>
Oliver, I wonder if as_str() could be made part of the public interface for Net::LDAP::FilterBuilder. In Oak::LDAP, I'm currently appending "" to a Net::LDAP::FilterBuilder object in order to force string context. It would be slightly neater and clearer if I could use a method call instead. I see that the stringification is implemented in terms of a method called "as_str", so my suggestion is to simply declare this as a public method in the documentation. I'm attaching a patch that does this. Since it adds a new section, METHODS, I've also added descriptions of and(), or(), and not(). Do let me know if I should be sending this elsewhere (eg rt.cpan.org). There's no hurry because forcing string context as described is working fine; I just think an explicit public to-string method would be an improvement. -- Tom Jones, Systems Development and Support Section Computing Services, University of Oxford

Message body is not shown because sender requested not to inline it.

On Mon Oct 19 16:19:52 2009, tom.jones@oucs.ox.ac.uk wrote: Show quoted text
> I wonder if as_str() could be made part of the public interface > for Net::LDAP::FilterBuilder. > > I'm attaching a patch that does this. Since it adds a new section, > METHODS, I've also added descriptions of and(), or(), and not().
This sounds very sensible - I'll apply the patch and do a new release. Many thanks indeed for that. -- regards, oliver.
Okay version 1.0003 now winging its way to CPAN, resolving this. -- regards, oliver.