Bug #50573 for Error:

Fri Oct 16 15:41:33 2009 bitcard [...] froods.org - Ticket created

CC:	nigelg [...] airg.com,karene [...] airg.com

Summary: "use strict; use warnings;" are missing in Error.pm after switching namespaces to Error::Simple, which mask the warning I describe below. The problem occurs when one passes no arguments to Error::Simple->new(). The warning that occurs is: Use of uninitialized value in concatenation (.) or string at /usr/lib/perl5/site_perl/5.8.8/Error.pm line 280. This line is: my $text = "" . shift; ---- The warning was originally encountered on a redhat box running perl5.8.5 and Error 0.17015. In perl5.8.8 there is no warning unless I add "use strict; use warnings;" above the constructor's declaration. However we all know that strict checking is highly recommended, as it can reveal problems that otherwise would remain silent. I would suggest changing line 280 to: my $text = "" . (shift || ""); --- credit goes to Nigel Gregoire (nigelg@airg.com) for finding this.

Mon Oct 19 14:39:27 2009 bitcard [...] froods.org - Status changed from 'new' to 'open'

Fri Dec 18 16:39:57 2009 SHLOMIF [...] cpan.org - Correspondence added

Subject:	use strict / use warnings throws an exception.
RT-Send-CC:	nigelg [...] airg.com, bitcard [...] froods.org

Hi! On Fri Oct 16 15:41:33 2009, bitcard@froods.org wrote: Show quoted text

> Summary: "use strict; use warnings;" are missing in Error.pm after > switching namespaces to Error::Simple, which mask the warning I describe > below. > > The problem occurs when one passes no arguments to Error::Simple->new(). > The warning that occurs is: > Use of uninitialized value in concatenation (.) or string at > /usr/lib/perl5/site_perl/5.8.8/Error.pm line 280. > > This line is: my $text = "" . shift; > > ---- > The warning was originally encountered on a redhat box running perl5.8.5 > and Error 0.17015. In perl5.8.8 there is no warning unless I add "use > strict; use warnings;" above the constructor's declaration. However we > all know that strict checking is highly recommended, as it can reveal > problems that otherwise would remain silent. I would suggest changing > line 280 to: > > my $text = "" . (shift || ""); >

It is unclear from your description what exactly is the problem. Can you provide a small testcase (a self-contained script) which demonstrates the problem? Regards, -- Shlomi Fish Show quoted text

> --- > credit goes to Nigel Gregoire (nigelg@airg.com) for finding this.

Thu Feb 04 05:49:54 2010 SHLOMIF [...] cpan.org - Correspondence added

Resolving as the original reporter hasn't responded to our query for essential information in over a month.

Thu Feb 04 05:49:55 2010 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Feb 04 05:49:56 2010 SHLOMIF [...] cpan.org - Given to SHLOMIF

Thu Feb 04 17:17:13 2010 bitcard [...] froods.org - Correspondence added

Subject:	Please reopen
From:	bitcard [...] froods.org

On Thu Feb 04 05:49:54 2010, SHLOMIF wrote: Show quoted text

> Resolving as the original reporter hasn't responded to our query for > essential information in over a month.

Please reopen (if this reply did not do so automatically).. Apologies, your replies got lost in my spam folder :( Repro steps (line numbers are for version 0.17016) 1. Edit Error.pm and add "use strict; use warnings;" on line 259 (just after "package Error::Simple;" 2. run: perl -MError -we'Error::Simple->new();' Observe the warning: Use of uninitialized value in concatenation (.) or string at /usr/lib/perl5/site_perl/5.8.8/Error.pm line 264. This is because of the line: 264: my $text = "" . shift;

Thu Feb 04 17:17:14 2010 The RT System itself - Status changed from 'resolved' to 'open'

Fri Feb 05 04:13:04 2010 SHLOMIF [...] cpan.org - Correspondence added

On Thu Feb 04 17:17:13 2010, bitcard@froods.org wrote: Show quoted text

> On Thu Feb 04 05:49:54 2010, SHLOMIF wrote:

> > Resolving as the original reporter hasn't responded to our query for > > essential information in over a month.

> > Please reopen (if this reply did not do so automatically).. > Apologies, your replies got lost in my spam folder :(

OK. Please make sure to whitelist them. Show quoted text

> > Repro steps (line numbers are for version 0.17016) > 1. Edit Error.pm and add "use strict; use warnings;" on line 259 (just > after "package Error::Simple;" > 2. run: perl -MError -we'Error::Simple->new();' > > Observe the warning: > Use of uninitialized value in concatenation (.) or string at > /usr/lib/perl5/site_perl/5.8.8/Error.pm line 264. > > This is because of the line: > 264: my $text = "" . shift; >

OK, I see it now. However, this warning is in place because the Error::Simple contract (see http://search.cpan.org/dist/Error/lib/Error/Simple.pm ) specifically says that Error::Simple accepts one compulsory text variable - «Error::Simple->new($text [, $value])». If you don't specify it - it's your problem. Can I close it now? Regards, -- Shlomi Fish

Mon Feb 08 20:19:09 2010 bitcard [...] froods.org - Correspondence added

Subject:	Re: [rt.cpan.org #50573]
Date:	Mon, 8 Feb 2010 17:17:56 -0800
To:	Shlomi Fish via RT <bug-Error [...] rt.cpan.org>
From:	Karen Etheridge <bitcard [...] froods.org>

On Fri, Feb 05, 2010 at 04:13:05AM -0500, Shlomi Fish via RT wrote: Show quoted text

> OK, I see it now. However, this warning is in place because the > Error::Simple contract (see > http://search.cpan.org/dist/Error/lib/Error/Simple.pm ) specifically > says that Error::Simple accepts one compulsory text variable - > «Error::Simple->new($text [, $value])». If you don't specify it - it's > your problem. > > Can I close it now?

Yes. --Ether

Tue Feb 09 07:47:15 2010 SHLOMIF [...] cpan.org - Correspondence added

Closing.

Tue Feb 09 07:47:18 2010 SHLOMIF [...] cpan.org - Status changed from 'open' to 'rejected'

Tue Oct 12 17:08:02 2010 RUZ_ADMIN - Requestor ETHER added

Tue Oct 12 17:08:02 2010 RUZ_ADMIN - Requestor bitcard@froods.org deleted