Skip Menu |

This queue is for tickets about the SQL-Translator CPAN distribution.

Report information
The Basics
Id: 50568
Status: resolved
Priority: 0/
Queue: SQL-Translator
People
Owner: Nobody in particular
Requestors: stephan [...] stejau.de
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.11003
Fixed in: 0.11011

History Show all quoted text
  Fri Oct 16 11:42:10 2009 stephan [...] stejau.de - Ticket created
Subject: Patch to prevent PostgreSQL Producer from dropping nameless Constraints
Hi, I attached an patch which prevents PostgreSQL Producer from deleting nameless Constraints and thous generating Invalid SQL. Sincerly, Stephan 'stephan48' Jauernick
Subject: pg_dont_drop_nameless_constraints.patch
851a852,854 > > return unless $c->name; >
  Sun Oct 18 08:32:07 2009 stephan [...] stejau.de - Correspondence added
I attached the same patch again but generated with diff -u :)
--- lib/SQL/Translator/Producer/PostgreSQL.pm 2009-10-03 20:08:31.000000000 +0200 +++ /home/linuxrulz/catalyst/LinuxRulz/lib/SQL/Translator/Producer/PostgreSQL.pm 2009-10-16 17:29:16.000000000 +0200 @@ -849,6 +849,9 @@ my ($c, $options) = @_; my $qt = $options->{quote_table_names} || ''; my $qc = $options->{quote_field_names} || ''; + + return unless $c->name; + my $out = sprintf('ALTER TABLE %s DROP CONSTRAINT %s', $qt . $c->table->name . $qt, $qc . $c->name . $qc );
  Sun Oct 18 08:32:10 2009 stephan [...] stejau.de - Status changed from 'new' to 'open'
  Thu Jan 19 03:56:44 2012 ribasushi [...] leporine.io - Correspondence added
This has been solved in a much more elegant way by c50d1a0afe9acf17c421acdfae25cf050b1da92e. Cheers!
  Thu Jan 19 03:56:45 2012 ribasushi [...] leporine.io - Status changed from 'open' to 'patched'
  Thu May 10 02:21:55 2012 ribasushi [...] leporine.io - Fixed in 0.11011 added
  Thu May 10 02:21:55 2012 ribasushi [...] leporine.io - Status changed from 'patched' to 'resolved'