Tue Oct 13 14:57:30 2009frank.l.cox [...] gmail.com - Ticket created
Tue Oct 13 14:58:36 2009frank.l.cox [...] gmail.com - Cc ptomblin@gmail.com added
Tue Oct 13 15:02:29 2009frank.l.cox [...] gmail.com - Correspondence added
Paul Tomblin sees:
Use of uninitialized value in numeric le (<=) at
/Library/Perl/5.10.0/Geo/ReadGRIB.pm line 546.
and later says:
The error happens because you initialize j to 1 and then reference
"time <= $times[j]", but in this file there is only one time, so
$times[j] is undefined.
That's no the only time you do that - there is a similar construct at
line 1005 and line 460.
Tue Oct 13 15:02:30 2009frank.l.cox [...] gmail.com - Status changed from 'new' to 'open'
Tue Oct 13 15:20:40 2009frank.l.cox [...] gmail.com - Correspondence added
This is a real bug though low severity and fairly easy to fix.
NOTE TO SELF: We have the same code in two places which violates DRY.
Also, extract() is really a special case of extractLaLo() except it has
the optional time arg which, if not present, extracts all times for that
one location... I should combine this code but maybe not as part of a
bug fix release.
Fri Oct 16 15:19:14 2009frank.l.cox [...] gmail.com - Correspondence added
This issue has been addressed in test version Geo-ReadGRIB-0.98_2.tar.gz
which has been uploaded to CPAN. It should show up in
http://cpan.perl.org/authors/id/F/FR/FRANKCOX/ soon.
This ticket will remain open pending testing.
Sun Oct 18 21:46:59 2009frank [...] pwizardry.com - Correspondence added
Subject:
Re: [rt.cpan.org #50460] warning seen when grib file has just one time
Date:
Sun, 18 Oct 2009 18:46:35 -0700
To:
bug-Geo-ReadGRIB [...] rt.cpan.org
From:
Frank Cox <frank [...] pwizardry.com>
I have not been able to reproduce this warning even with Perl 5.10.0 but
I see the lines in the old code that would have been undefined in the
case of GRIB files with only one time.
Waiting for word from the reporter.
--Frank Cox
Sun Oct 18 21:49:38 2009ptomblin [...] xcski.com - Correspondence added
Subject:
Re: [rt.cpan.org #50460] warning seen when grib file has just one time
Date:
Sun, 18 Oct 2009 21:49:24 -0400
To:
bug-Geo-ReadGRIB [...] rt.cpan.org
From:
Paul Tomblin <ptomblin [...] xcski.com>
I'm not seeing that error any more.
On Sun, Oct 18, 2009 at 9:47 PM, Frank Cox via RT
<bug-Geo-ReadGRIB@rt.cpan.org> wrote:
Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=50460 >
>
> I have not been able to reproduce this warning even with Perl 5.10.0 but
> I see the lines in the old code that would have been undefined in the
> case of GRIB files with only one time.
>
> Waiting for word from the reporter.
>
> --Frank Cox
>
>
RT for rt.cpan.org