Skip Menu |

This queue is for tickets about the Test-Group CPAN distribution.

Report information
The Basics
Id: 50265
Status: resolved
Priority: 0/
Queue: Test-Group

People
Owner: Nobody in particular
Requestors: toddr [...] null.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.14
Fixed in: (no value)



Subject: 10-external.t failing on Mac Snow Leopard (64 bit)
not ok 21 - dont_catch_exceptions # Failed test 'dont_catch_exceptions' # at t/10-external.t line 158. # got: '29' # expected: '255'
From: toddr [...] null.net
Tests are even uglier on v12 PERL_DL_NONLAZY=1 /usr/local/perl/510/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00-load.t ............... 1/1 # Testing Test::Group 0.12, Perl 5.010001, /usr/local/perl/510/bin/perl t/00-load.t ............... ok t/10-external.t ........... 1/33 # Failed test at t/10-external.t line 48. # got: '1..1 # not ok 1 - *died* group # ' # expected: '1..1 # not ok 1 - group # ' # Failed test 'got bla' # at t/10-external.t line 52. # '# Test ``group'' died: # # Can't locate object method "_print_diag" via package "Test::Builder::_HijackedByTestGroup" at /Users/compile/.cpan/build/Test-Group-0.12-o8VSD8/blib/lib/Test/Group.pm line 749. # # # Failed test '*died* group' # # at - line 8. # # Looks like you failed 1 test of 1. # ' # doesn't match '(?-xism:got:.*bla)' # Failed test 'expected ble' # at t/10-external.t line 53. # '# Test ``group'' died: # # Can't locate object method "_print_diag" via package "Test::Builder::_HijackedByTestGroup" at /Users/compile/.cpan/build/Test-Group-0.12-o8VSD8/blib/lib/Test/Group.pm line 749. # # # Failed test '*died* group' # # at - line 8. # # Looks like you failed 1 test of 1. # ' # doesn't match '(?-xism:expected:.*ble)' # Failed test 'another subtest failed' # at t/10-external.t line 54. # '# Test ``group'' died: # # Can't locate object method "_print_diag" via package "Test::Builder::_HijackedByTestGroup" at /Users/compile/.cpan/build/Test-Group-0.12-o8VSD8/blib/lib/Test/Group.pm line 749. # # # Failed test '*died* group' # # at - line 8. # # Looks like you failed 1 test of 1. # ' # doesn't match '(?i-xsm:failed.*sub test blah)' # Failed test at t/10-external.t line 105. # got: '1..3 # ok 1 - group 1 # not ok 2 - *died* group 2 # ok 3 # skip <reason> # ' # expected: '1..3 # ok 1 - group 1 # not ok 2 - group 2 # ok 3 # skip <reason> # ' # Failed test 'dont_catch_exceptions' # at t/10-external.t line 158. # got: '29' # expected: '255' # Failed test at t/10-external.t line 171. # 'coucou at - line 6. # # Looks like your test exited with 29 before it could output anything. # ' # doesn't match '(?i-xsm:no tests run|test died before it could)' # Failed test at t/10-external.t line 236. # got: '1..2 # ok 1 - outer 1 # not ok 2 - *died* outer 2 # ' # expected: '1..2 # ok 1 - outer 1 # not ok 2 - outer 2 # ' # Test ``inner 1'' died: # Died at - line 15. # Test ``outer 2'' died: # Can't locate object method "_print_diag" via package "Test::Builder::_HijackedByTestGroup" at /Users/compile/.cpan/build/Test-Group-0.12-o8VSD8/blib/lib/Test/Group.pm line 749. # Failed test '*died* outer 2' # at - line 20. # Looks like you failed 1 test of 2. # Looks like you failed 8 tests of 33. t/10-external.t ........... Dubious, test returned 8 (wstat 2048, 0x800) Failed 8/33 subtests t/20-internal.t ........... ok t/30-synopsis.t ........... 1/15 # Failed test 'success is_failed' # at t/30-synopsis.t line 60. # Failed test 'failure prints_OK' # at t/30-synopsis.t line 67. # Failed test 'todo is_failed' # at t/30-synopsis.t line 72. # Failed test 'todo prints_OK' # at t/30-synopsis.t line 73. # Failed test 'todo is_failed' # at t/30-synopsis.t line 72. # Failed test 'todo prints_OK' # at t/30-synopsis.t line 73. # Looks like you failed 6 tests of 15. t/30-synopsis.t ........... Dubious, test returned 6 (wstat 1536, 0x600) Failed 6/15 subtests t/32-nested-skipping.t .... ok t/35-todotests.t .......... 1/58 # Failed test at t/35-todotests.t line 34. # '(no TODO explanation)' # doesn't match '(?-xism:tout doux)' # Failed test at t/35-todotests.t line 49. # '(no TODO explanation)' # doesn't match '(?-xism:in the test name)' # Failed test at t/35-todotests.t line 57. # '(no TODO explanation)' # doesn't match '(?-xism:in the test name)' # Failed test at t/35-todotests.t line 70. # Failed test at t/35-todotests.t line 71. # Failed test at t/35-todotests.t line 74. # Failed test at t/35-todotests.t line 75. # Failed test at t/35-todotests.t line 127. # Failed test at t/35-todotests.t line 128. # Failed test at t/35-todotests.t line 192. # Failed test at t/35-todotests.t line 193. # Failed test at t/35-todotests.t line 265. # Failed test at t/35-todotests.t line 272. # Failed test '"TODO correct" prints_OK' # at t/35-todotests.t line 273. # Failed test at t/35-todotests.t line 281. # Failed test at t/35-todotests.t line 282. # Failed test at t/35-todotests.t line 296. # Failed test at t/35-todotests.t line 297. # Failed test 'TODO group, failing' # at t/35-todotests.t line 306. # got: '1' # expected: '0' # Failed test 'would nonetheless be treated as a success by Test::Harness' # at t/35-todotests.t line 327. # '1..1 # not ok 1 - *died* TODO sub-test (normal i.e. failing) # ' # doesn't match '(?-xism:not ok 1.*# TODO )' # Failed test 'all TODO reasons concatenated' # at t/35-todotests.t line 329. # '1..1 # not ok 1 - *died* TODO sub-test (normal i.e. failing) # ' # doesn't match '(?-xism:Not quite there yet.*Need more budget)' # Looks like you failed 21 tests of 58. t/35-todotests.t .......... Dubious, test returned 21 (wstat 5376, 0x1500) Failed 21/58 subtests t/40-exception-objects.t .. ok t/50-error-reporting.t .... 1/5 # Failed test 'sub-test failure reported at the correct line' # at t/50-error-reporting.t line 46. # '# Test ``this fails'' died: # # Can't locate object method "_print_diag" via package "Test::Builder::_HijackedByTestGroup" at /Users/compile/.cpan/build/Test-Group-0.12-o8VSD8/blib/lib/Test/Group.pm line 749. # # # Failed test '*died* this fails' # # at /tmp/Test-Group-rC3glF/test.pl line 8. # # Looks like you failed 1 test of 1. # ' # doesn't match '(?-xism:oops.*\n.*\/tmp\/Test\-Group\-rC3glF\/test\.pl.*line 7)' # Looks like you failed 1 test of 5. t/50-error-reporting.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests Test Summary Report ------------------- t/10-external.t (Wstat: 2048 Tests: 33 Failed: 8) Failed tests: 6-9, 16, 21, 23, 33 Non-zero exit status: 8 t/30-synopsis.t (Wstat: 1536 Tests: 15 Failed: 6) Failed tests: 2, 9, 12-15 Non-zero exit status: 6 t/35-todotests.t (Wstat: 5376 Tests: 58 Failed: 21) Failed tests: 3, 6, 9-13, 21-22, 31-32, 46-48, 50-51 53-54, 56-58 Non-zero exit status: 21 t/50-error-reporting.t (Wstat: 256 Tests: 5 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=8, Tests=135, 1 wallclock secs ( 0.05 usr 0.03 sys + 0.94 cusr 0.25 csys = 1.27 CPU) Result: FAIL Failed 4/8 test programs. 36/135 subtests failed. make: *** [test_dynamic] Error 1
On Tue Oct 06 16:09:11 2009, todd_rinaldo wrote: Show quoted text
> not ok 21 - dont_catch_exceptions > > # Failed test 'dont_catch_exceptions' > # at t/10-external.t line 158. > # got: '29' > # expected: '255'
I think I can see how to fix this, but I don't have access to a Snow Leopard box. Could you try it with the attached patch please ? (I'm not a Test::Group maintainer BTW, just an interested person)
diff -Nurd Test-Group-0.14.orig/t/10-external.t Test-Group-0.14/t/10-external.t --- Test-Group-0.14.orig/t/10-external.t 2008-09-12 18:05:23.000000000 +0200 +++ Test-Group-0.14/t/10-external.t 2009-10-11 21:28:32.000000000 +0200 @@ -155,7 +155,7 @@ not ok 3 - other group EOOUT -is $perl->run(stdin => <<'EOSCRIPT') >> 8, 255, "dont_catch_exceptions"; +ok $perl->run(stdin => <<'EOSCRIPT') >> 8, "dont_catch_exceptions"; use Test::More tests => 1; use Test::Group; Test::Group->dont_catch_exceptions();
From: todd.e.rinaldo [...] jpmorgan.com
Yes, that patch does fix things. I'm not sure I follow the change though
On Mon Oct 12 14:27:59 2009, todd_rinaldo wrote: Show quoted text
> Yes, that patch does fix things. I'm not sure I follow the change though
That test was checking that a particular test script fails, by looking for an exit status of 255. It seems that failing test scripts sometimes exit with status 29 instead of 255. The patch broadens the definition of success for that test, so that it accepts any non-zero exit status as a pass.
Subject: Re: [rt.cpan.org #50265] 10-external.t failing on Mac Snow Leopard (64 bit)
Date: Mon, 19 Oct 2009 14:43:10 +0200
To: bug-Test-Group [...] rt.cpan.org
From: Dominique Quatravaux <domq [...] cpan.org>
On Mon, Oct 12, 2009 at 10:29 AM, NCLEATON via RT <bug-Test-Group@rt.cpan.org> wrote: Show quoted text
> (I'm not a Test::Group maintainer BTW, just an interested person)
Well now you are :-) Thanks for tracking this down! -- Dominique Quatravaux +41 79 609 40 72
This is fixed in version 0.15