Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the ELF-Extract-Sections CPAN distribution.

Report information
The Basics
Id: 50124
Status: resolved
Priority: 0/
Queue: ELF-Extract-Sections

People
Owner: Nobody in particular
Requestors: frequency [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.0105
Fixed in: (no value)



Subject: Failure in t/00-load.t: "use ok" used, but not required
Hi: Currently the load test uses: use ok 'ELF::Extract::Sections'; This syntax is supported by the Test::use::ok module, not Test::More. Consequently, unless you have that module installed, the test will fail. I recommend simply changing it to "use_ok" so as to not require additional dependencies (as compared to Test::More, which is in core anyway) Cheers, Jonathan FWIW: it basically blows up like this, and I'm surprised you haven't seen CPAN Testers reports on it yet -- Can't locate ok.pm in @INC (@INC contains: /build/jon-libelf-extract-sections-perl_0.0105-1-i386-1I6tie/libelf-extract-sections-perl-0.0105/blib/lib /build/jon-libelf-extract-sections-perl_0.0105-1-i386-1I6tie/libelf-extract-sections-perl-0.0105/blib/arch /etc/perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl . /etc/perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at t/00-load.t line 5. BEGIN failed--compilation aborted at t/00-load.t line 5. # Looks like your test died before it could output anything. t/00-load.................dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED test 1 Failed 1/1 tests, 0.00% okay
Here is the patch used in Debian to fix this issue: Description: use "use_ok" instead of "use ok" The "use ok" syntax is supported by Test::use::ok, a non-core module. It provides functionality equivalent to use_ok, which is provided by Test::More (which is a core module). Author: Jonathan Yu <jawnsy@cpan.org> Origin: vendor Forwarded: yes Bug-CPAN: http://rt.cpan.org/Ticket/Display.html?id=50124 --- a/t/00-load.t +++ b/t/00-load.t @@ -2,6 +2,6 @@ use Test::More tests => 1; -use ok 'ELF::Extract::Sections'; +use_ok 'ELF::Extract::Sections'; diag( "Testing ELF::Extract::Sections $ELF::Extract::Sections::VERSION, Perl $], $^X" );
On Thu Nov 19 15:58:29 2009, FREQUENCY wrote: Show quoted text
> Here is the patch used in Debian to fix this issue: > > Description: use "use_ok" instead of "use ok" > The "use ok" syntax is supported by Test::use::ok, a non-core > module. It provides functionality equivalent to use_ok, which > is provided by Test::More (which is a core module). > Author: Jonathan Yu <jawnsy@cpan.org> > Origin: vendor > Forwarded: yes > Bug-CPAN: http://rt.cpan.org/Ticket/Display.html?id=50124 > --- a/t/00-load.t > +++ b/t/00-load.t > @@ -2,6 +2,6 @@ > > use Test::More tests => 1; > > -use ok 'ELF::Extract::Sections'; > +use_ok 'ELF::Extract::Sections'; > > diag( "Testing ELF::Extract::Sections $ELF::Extract::Sections::VERSION, > Perl $], $^X" );
I am aware of the simplicity of this fix, however, the stagnation on releasing a fixed revision is for other reasons ;)
Also, FWIW, I'll be using http://search.cpan.org/~jquelin/Dist-Zilla-Plugin-CompileTests-1.092870/ . This wont add any extra dependencies ( it injects a generated .t at release time ), but will make it brainless for testing things.
This should be resolved in 0.02020308 when it hits CPAN. Note the absence of 00-load.t and the addition of 00-compile.t http://github.com/kentfredric/ELF-Extract-Sections/tree/0.02020308/t http://github.com/kentfredric/ELF-Extract-Sections/blob/0.02020308/t/00-compile.t Please test it and let me know you're happy.