Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Git-Wrapper CPAN distribution.

Report information
The Basics
Id: 50113
Status: resolved
Priority: 0/
Queue: Git-Wrapper
People
Owner: GENEHACK [...] cpan.org
Requestors: james.s.white [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.007
Fixed in: (no value)

History Show all quoted text
  Tue Sep 29 21:11:07 2009 https://me.yahoo.com/a/Fbxg6dsUlvWhwkgRXfNscIv7MqW2cr0t#83027 - Ticket created
Subject: test fails on debian lenny due to change error message
# Failed test at t/basic.t line 45. # 'git: 'a-command-not-likely-to-exist' is not a git-command. See 'git --help'. # ' # doesn't match '(?-xism:which does not exist)' # Looks like you failed 1 test of 10.
  Tue Sep 29 21:21:05 2009 https://me.yahoo.com/a/Fbxg6dsUlvWhwkgRXfNscIv7MqW2cr0t#83027 - Correspondence added
On Tue Sep 29 21:11:07 2009, https://me.yahoo.com/a/Fbxg6dsUlvWhwkgRXfNscIv7MqW2cr0t#83027 wrote: Show quoted text
> # Failed test at t/basic.t line 45. > # 'git: 'a-command-not-likely-to-exist' is not a > git-command. See 'git --help'. > # ' > # doesn't match '(?-xism:which does not exist)' > # Looks like you failed 1 test of 10.
on debian/lenny: $ git --version git version 1.5.6.5 $ git a-command-not-likely-to-exist git: 'a-command-not-likely-to-exist' is not a git-command. See 'git --help'. in t/basic.t eval { $git->a_command_not_likely_to_exist }; ok(my $e = $@, "got an error"); if ($git->version lt '1.6') { like($e, qr/which does not exist/); } else { like($e, qr/is not a git-command/); }
  Tue Sep 29 21:21:06 2009 The RT System itself - Status changed from 'new' to 'open'
  Wed Mar 17 12:31:44 2010 cpan [...] prather.org - Correspondence added
On Tue Sep 29 21:21:05 2009, https://me.yahoo.com/a/Fbxg6dsUlvWhwkgRXfNscIv7MqW2cr0t#83027 wrote: Show quoted text
> On Tue Sep 29 21:11:07 2009, >
https://me.yahoo.com/a/Fbxg6dsUlvWhwkgRXfNscIv7MqW2cr0t#83027 wrote: Show quoted text
> > # Failed test at t/basic.t line 45. > > # 'git: 'a-command-not-likely-to-exist' is not a > > git-command. See 'git --help'. > > # ' > > # doesn't match '(?-xism:which does not exist)' > > # Looks like you failed 1 test of 10.
> > on debian/lenny: > > $ git --version > git version 1.5.6.5 > $ git a-command-not-likely-to-exist > git: 'a-command-not-likely-to-exist' is not a git-command. See 'git
--help'. Show quoted text
> > in t/basic.t > eval { $git->a_command_not_likely_to_exist }; > ok(my $e = $@, "got an error"); > if ($git->version lt '1.6') { > like($e, qr/which does not exist/); > } else { > like($e, qr/is not a git-command/); > } > >
Thanks to mschout this should be fixed in 0.008 heading to CPAN. Expect a 0.009 soon to clean up some other issues I've found with docs etc.
  Wed Mar 31 13:16:35 2010 mjgardner [...] cpan.org - Correspondence added
This is still broken in 0.008 running on RHEL 5 with git 1.5.2.1. See attached. On Wed Mar 17 12:31:44 2010, PERIGRIN wrote: Show quoted text
> On Tue Sep 29 21:21:05 2009, > https://me.yahoo.com/a/Fbxg6dsUlvWhwkgRXfNscIv7MqW2cr0t#83027 > wrote:
> > On Tue Sep 29 21:11:07 2009, > >
> https://me.yahoo.com/a/Fbxg6dsUlvWhwkgRXfNscIv7MqW2cr0t#83027 > wrote:
> > > # Failed test at t/basic.t line 45. > > > # 'git: 'a-command-not-likely-to-exist' is not a > > > git-command. See 'git --help'. > > > # ' > > > # doesn't match '(?-xism:which does not exist)' > > > # Looks like you failed 1 test of 10.
> > > > on debian/lenny: > > > > $ git --version > > git version 1.5.6.5 > > $ git a-command-not-likely-to-exist > > git: 'a-command-not-likely-to-exist' is not a git-command. See 'git
> --help'.
> > > > in t/basic.t > > eval { $git->a_command_not_likely_to_exist }; > > ok(my $e = $@, "got an error"); > > if ($git->version lt '1.6') { > > like($e, qr/which does not exist/); > > } else { > > like($e, qr/is not a git-command/); > > } > > > >
> > > Thanks to mschout this should be fixed in 0.008 heading to CPAN. > Expect a 0.009 soon to clean up some other issues I've found with
docs Show quoted text
> etc.
Subject: git-wrapper_fail.txt
# Testing Git::Wrapper 0.008 t/00-load.t ....... ok # Failed test 'got an error' # at t/basic.t line 43. # Failed test at t/basic.t line 45. # '' # doesn't match '(?-xism:which does not exist)' fatal: unknown date format --date=iso # Looks like you failed 2 tests of 6. # Looks like your test exited with 128 just after 6. t/basic.t ......... Dubious, test returned 128 (wstat 32768, 0x8000) Failed 2/6 subtests t/pod-coverage.t .. ok t/pod.t ........... ok Test Summary Report ------------------- t/basic.t (Wstat: 32768 Tests: 6 Failed: 2) Failed tests: 5-6 Non-zero exit status: 128 Files=4, Tests=9, 0 wallclock secs ( 0.02 usr 0.02 sys + 0.25 cusr 0.15 csys = 0.44 CPU) Result: FAIL Failed 1/4 test programs. 2/9 subtests failed. make: *** [test_dynamic] Error 255
  Tue Apr 27 09:29:28 2010 http://xenoterracide.blogspot.com/ - Correspondence added
Show quoted text
> Thanks to mschout this should be fixed in 0.008 heading to CPAN. > Expect a 0.009 soon to clean up some other issues I've found with docs > etc.
Broken on arch with git 1.7.1 too
  Sat May 08 22:43:33 2010 MITHALDU [...] cpan.org - Correspondence added
This fails on Windows too. Specifically: Despite the error occurring as planned, and the error output being captured, $? is ALWAYS set to '0' once waitpid is run. This also happens for error-less results. As such, i think it is best to simply change: if ($?) { to if (@err) { And to stop relying on $? as an error indicator.
  Mon May 10 04:53:48 2010 MITHALDU [...] cpan.org - Correspondence added
After further investigations i have to report that my previous message was completely wrong and hare-brained. On Windows git.cmd has a (fixable) issue that prevents it from forwarding the return value. I fixed that on my system and Git::Wrapper receives the return value just fine now.
  Fri Jul 08 22:29:41 2011 GENEHACK [...] cpan.org - Correspondence added
On Mon May 10 04:53:48 2010, MITHALDU wrote: Show quoted text
> After further investigations i have to report that my previous message > was completely wrong and hare-brained. > > On Windows git.cmd has a (fixable) issue that prevents it from forwarding > the return value. I fixed that on my system and Git::Wrapper receives the > return value just fine now.
It looks like all the issues in this ticket have been fixed -- all tests pass cleanly on a Debian system for me. Closing this ticket. chrs, john.
  Fri Jul 08 22:29:42 2011 GENEHACK [...] cpan.org - Status changed from 'open' to 'resolved'
  Fri Jul 08 22:29:45 2011 GENEHACK [...] cpan.org - Taken