Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the URI-Find CPAN distribution.

Report information
The Basics
Id: 50018
Status: resolved
Priority: 0/
Queue: URI-Find

People
Owner: Nobody in particular
Requestors: darren [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 20090316
  • 20090319
Fixed in: (no value)



Subject: Change in format of returned URIs
As of version 20090316, URIs in HTML are now including ahref=" in the output: use lib '/tmp/URI-Find-20090316/lib'; use URI::Find; $x = 'I like <a href="http://www.boston.com">boston.com</a>'; URI::Find->new(sub { print "$_[0]" })->find(\$x) ahref=%22http://www.boston.com This was not a problem in previous versions: use lib '/tmp/URI-Find-0.16/lib'; use URI::Find; $x = 'I like <a href="http://www.boston.com">boston.com</a>'; URI::Find->new(sub { print "$_[0]" })->find(\$x) http://www.boston.com/ I didn't see mention of any seemingly relevant changes in the Changes file for version 20090316 (I haven't had the time to look through the code yet), and I didn't notice any change to the documented interface in the POD.
Subject: Re: [rt.cpan.org #50018] Change in format of returned URIs
Date: Fri, 25 Sep 2009 16:08:31 -0700
To: bug-URI-Find [...] rt.cpan.org
From: Michael G Schwern <schwern [...] pobox.com>
Darren Chamberlain via RT wrote: Show quoted text
> As of version 20090316, URIs in HTML are now including ahref=" in the > output: > > use lib '/tmp/URI-Find-20090316/lib'; > use URI::Find; > $x = 'I like <a href="http://www.boston.com">boston.com</a>'; > URI::Find->new(sub { print "$_[0]" })->find(\$x) > > ahref=%22http://www.boston.com > > This was not a problem in previous versions: > > use lib '/tmp/URI-Find-0.16/lib'; > use URI::Find; > $x = 'I like <a href="http://www.boston.com">boston.com</a>'; > URI::Find->new(sub { print "$_[0]" })->find(\$x) > > http://www.boston.com/ > > I didn't see mention of any seemingly relevant changes in the Changes > file for version 20090316 (I haven't had the time to look through the > code yet), and I didn't notice any change to the documented interface in > the POD.
That would be because its a bug. -- But there's no sense crying over every mistake. You just keep on trying till you run out of cake. -- Jonathan Coulton, "Still Alive"
On Fri Sep 25 19:08:53 2009, schwern@pobox.com wrote: Show quoted text
> > I didn't see mention of any seemingly relevant changes in the Changes > > file for version 20090316 (I haven't had the time to look through the > > code yet), and I didn't notice any change to the documented interface in > > the POD.
> > That would be because its a bug.
I agree it's a bug, but it seems that this line from the Changes file is the cause: * Whitespace inside <...> is now ignored as per the suggestion of RFC 3986 appendix C. [rt.cpan.org 20483]
On Thu Feb 04 15:39:06 2010, WONKO wrote: Show quoted text
> I agree it's a bug, but it seems that this line from the Changes file is > the cause:
I've fixed this in my github fork (http://github.com/mpeters/uri-find)
Thanks, I was working on a clean rewrite of the whole thing but that's stalled out.