Skip Menu |

This queue is for tickets about the RPC-XML CPAN distribution.

Report information
The Basics
Id: 50013
Status: resolved
Priority: 0/
Queue: RPC-XML

People
Owner: rjray [...] blackperl.com
Requestors: kane [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.69
Fixed in: 0.70



Subject: Backwards incompatible critical change
Instantiating an XML parser no longer works like it did in 0.67: $ perl -MRPC::XML::Parser -le'print RPC::XML::Parser->new' RPC::XML::Parser::new: This method should have been overridden by the RPC::XML::Parser class at /opt/5.10.0/lib/perl5/site_perl/5.10.0/RPC/XML/Parser.pm line 46. However, this is exactly what the Synopsis of RPC::XML tells us to do: use RPC::XML; ... $resp = RPC::XML::Parser->new()->parse(STREAM); This breaks Catalyst::Plugin::Server::XMLRPC among others.
I overlooked the reference to direct use of RPC::XML::Parser in the POD for RPC::XML. I will address this with two fixes: (1) Correct the documentation to refer to RPC::XML::ParserFactory, and (2) Make the constructor for RPC::XML::Parser handle a special-case that hands off to the factory constructor. If I cannot finish the other changes scheduled for 0.70 in a reasonable span of time, I will release a 0.691. To be honest, I didn't know anyone was using the parser class directly like this, and I worried only about keeping the interface to the client and server classes consistent. I apologize for this. As an interim fix, if you replace RPC::XML::Parser with RPC::XML::ParserFactory in the Catalyst class, it should work. However, that would require making that package dependent specifically on the 0.69 version of this module. See the documentation for RPC::XML::Parser and RPC::XML::ParserFactory in the 0.69 distribution. (Note that due to an oversight on my part, the RPC::XML::ParserFactory documentation refers to an option based on XML::LibXML, which was not ready for the 0.69 version. The references to it should have been removed, as currently only the XML::Parser implementation is available.) -- """"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" Randy J. Ray Silicon Valley Scale Modelers: http://www.svsm.org rjray@blackperl.com randy.j.ray@gmail.com
Subject: Re: [rt.cpan.org #50013] Backwards incompatible critical change
Date: Thu, 1 Oct 2009 21:54:30 +0200
To: bug-RPC-XML [...] rt.cpan.org
From: gregor herrmann <gregoa [...] debian.org>
We've encountered this problem also in Debian: http://bugs.debian.org/548930 Since it breaks other software (some examples are mentioned in the bug report above) a fix (be it in 0.70 or 0.691) would be much appreciated. Thanks, gregor, Debian Perl Group -- .''`. http://info.comodo.priv.at/ -- GPG Key IDs: 0x00F3CFE4, 0x8649AA06 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/ `- NP: Beatles
Download signature.asc
application/pgp-signature 198b

Message body not shown because it is not plain text.

Fixed in 0.70. Calls to create an instance of RPC::XML::Parser directly now special-case to calling the parser-factory behind the scenes. -- """"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" Randy J. Ray Silicon Valley Scale Modelers: http://www.svsm.org rjray@blackperl.com randy.j.ray@gmail.com