Skip Menu |

This queue is for tickets about the Smolder CPAN distribution.

Report information
The Basics
Id: 49992
Status: open
Priority: 0/
Queue: Smolder
People
Owner: Nobody in particular
Requestors: MARKSTOS [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in: 1.40
Fixed in: (no value)

History Show all quoted text
  Thu Sep 24 16:52:44 2009 MARKSTOS [...] cpan.org - Ticket created
Subject: wish: diagnostic should be improved: "File 'out.tgz' is not of the correct type!"
I used "prove --archive" and tried to upload it to Smolder with smolder_smoke_signal. I got back this diagnostic: File 'out.tgz' is not of the correct type! I wish the diagnostic were improved to tell me what the correct type is. Mark
  Thu Sep 24 16:59:33 2009 MARKSTOS [...] cpan.org - Correspondence added
On Thu Sep 24 16:52:44 2009, MARKSTOS wrote: Show quoted text
> I used "prove --archive" and tried to upload it to Smolder with > smolder_smoke_signal. I got back this diagnostic: > > File 'out.tgz' is not of the correct type! > > I wish the diagnostic were improved to tell me what the correct type is.
I looked into this further. I think this line in smolder_smoke_signal should be improved: unless ($file =~ /\.tar(\.gz)?$/) { Specifically, it should accept ".tgz" as a valid extension. (But the diagnostics should still be improved.)
  Thu Sep 24 16:59:34 2009 MARKSTOS [...] cpan.org - Status changed from 'new' to 'open'
  Thu Sep 24 21:14:17 2009 MARKSTOS [...] cpan.org - Correspondence added
I have patch for this on Github now: http://github.com/markstos/smolder/commit/b2a003d9eab6c697808bfb6c01566dbb05b868c2