Skip Menu |

This queue is for tickets about the TimeDate CPAN distribution.

Report information
The Basics
Id: 49963
Status: resolved
Priority: 0/
Queue: TimeDate
People
Owner: Nobody in particular
Requestors: kmx [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.17
Fixed in: (no value)

History Show all quoted text
  Thu Sep 24 05:00:33 2009 kmx [...] cpan.org - Ticket created
Subject: 1.17 tests fail on Win32/Strawberry perl
Hi, I have experienced the following failures with v1.17 during tests on Win32/Strawberry perl (tested on both 5.10.1/5.8.9): Running make test D:\strawberry\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib\lib', 'blib\arch')" t/*.t t/cpanrt.t ... ok Use of uninitialized value in integer addition (+) at D:/STRAWB~1/perl/lib/Time/Local.pm line 85. Use of uninitialized value in integer multiplication (*) at D:/STRAWB~1/perl/lib/Time/Local.pm line 85. Use of uninitialized value in integer multiplication (*) at D:/STRAWB~1/perl/lib/Time/Local.pm line 85. t/date.t ..... Use of uninitialized value in pack at D:/STRAWB~1/perl/lib/Time/Local.pm line 69. Use of uninitialized value in pack at D:/STRAWB~1/perl/lib/Time/Local.pm line 69. Use of uninitialized value in integer addition (+) at D:/STRAWB~1/perl/lib/Time/Local.pm line 70. Use of uninitialized value in integer addition (+) at D:/STRAWB~1/perl/lib/Time/Local.pm line 71. Use of uninitialized value in integer addition (+) at D:/STRAWB~1/perl/lib/Time/Local.pm line 69. Use of uninitialized value in integer ne (!=) at D:/STRAWB~1/perl/lib/Time/Local.pm line 178. Use of uninitialized value in array element at D:\strawberry\cpan\build\TimeDate-1.17-gW8quC\blib\lib/Date/Format.pm line 198. Use of uninitialized value in array element at D:\strawberry\cpan\build\TimeDate-1.17-gW8quC\blib\lib/Date/Format.pm line 200. Use of uninitialized value in sprintf at D:\strawberry\cpan\build\TimeDate-1.17-gW8quC\blib\lib/Date/Format.pm line 207. Use of uninitialized value in sprintf at D:\strawberry\cpan\build\TimeDate-1.17-gW8quC\blib\lib/Date/Format.pm line 208. Use of uninitialized value in sprintf at D:\strawberry\cpan\build\TimeDate-1.17-gW8quC\blib\lib/Date/Format.pm line 215. Use of uninitialized value in sprintf at D:\strawberry\cpan\build\TimeDate-1.17-gW8quC\blib\lib/Date/Format.pm line 222. Use of uninitialized value in addition (+) at D:\strawberry\cpan\build\TimeDate-1.17-gW8quC\blib\lib/Date/Format.pm line 227. Use of uninitialized value in integer ge (>=) at D:/STRAWB~1/perl/lib/Time/Local.pm line 94. Use of uninitialized value in integer lt (<) at D:/STRAWB~1/perl/lib/Time/Local.pm line 94. Use of uninitialized value in integer ge (>=) at D:/STRAWB~1/perl/lib/Time/Local.pm line 94. Use of uninitialized value in integer gt (>) at D:/STRAWB~1/perl/lib/Time/Local.pm line 98. Use of uninitialized value in integer gt (>) at D:/STRAWB~1/perl/lib/Time/Local.pm line 102. Use of uninitialized value in integer lt (<) at D:/STRAWB~1/perl/lib/Time/Local.pm line 102. Use of uninitialized value in array element at D:/STRAWB~1/perl/lib/Time/Local.pm line 106. Use of uninitialized value in integer eq (==) at D:/STRAWB~1/perl/lib/Time/Local.pm line 107. Use of uninitialized value in integer gt (>) at D:/STRAWB~1/perl/lib/Time/Local.pm line 110. Use of uninitialized value in integer lt (<) at D:/STRAWB~1/perl/lib/Time/Local.pm line 110. Use of uninitialized value in concatenation (.) or string at D:/STRAWB~1/perl/lib/Time/Local.pm line 110. Day '' out of range 1..31 at D:\strawberry\cpan\build\TimeDate-1.17-gW8quC\blib\lib/Date/Format.pm line 230 t/date.t ..... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 144/148 subtests t/format.t ... ok t/getdate.t .. ok t/lang.t ..... ok Test Summary Report ------------------- t/date.t (Wstat: 65280 Tests: 4 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 148 tests but ran 4. Files=5, Tests=310, 3 wallclock secs ( 0.11 usr + 0.05 sys = 0.16 CPU) Result: FAIL Failed 1/5 test programs. 0/310 subtests failed. dmake.EXE: Error code 255, while making 'test_dynamic' GBARR/TimeDate-1.17.tar.gz D:\strawberry\c\bin\dmake.EXE test -- NOT OK //hint// to see the cpan-testers results for installing this module, try: reports GBARR/TimeDate-1.17.tar.gz Running make install make test had returned bad status, won't install without force The previous version 1.16 install without any trouble. Maybe important notice: I am using non-english locale on my Windows box -- kmx
  Thu Sep 24 06:01:35 2009 kmx [...] cpan.org - Correspondence added
It seems that the problem is with negative dates/timestamps (before 01/01/1970) that are not well supported on Win32. It might be somehow related to a note at: http://search.cpan.org/~dapm/perl-5.10.1/pod/perlport.pod#Time_and_Date saying: "On Windows (at least), you shouldn't pass a negative value to gmtime or localtime." -- kmx
  Thu Sep 24 06:01:36 2009 kmx [...] cpan.org - Status changed from 'new' to 'open'
  Thu Sep 24 09:41:17 2009 gbarr [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #49963] 1.17 tests fail on Win32/Strawberry perl
Date: Thu, 24 Sep 2009 08:40:50 -0500
To: bug-TimeDate [...] rt.cpan.org
From: Graham Barr <gbarr [...] pobox.com>
So on win32 time did not exists before 01/01/1970 :-) there are only 4 dates in the tests that are pre-1970 so that seems like a lot of warnings. Can you run perl -w -Ilib t/date.t that should help see what dates are causing the issue. Hm, actually looking at date.t stdout is still buffered so will not mix correctly with stderr. Add $|=1; to the top of that script and run as above.
  Thu Sep 24 09:48:00 2009 kmx [...] cpan.org - Correspondence added
The output of: perl -w -Ilib t/date.t 1..148 ok 1 1995-01-24 Mon Jan 23 23:00:00 1995 GMT ok 2 1995-01-24T09:08:17.1823213 Tue Jan 24 08:08:17 1995 GMT ok 3 Use of uninitialized value in integer addition (+) at C:/strawberry/perl/lib/Time/Local.pm line 85. Use of uninitialized value $_[1] in integer multiplication (*) at C:/strawberry/perl/lib/Time/Local.pm line 85. Use of uninitialized value $_[2] in integer multiplication (*) at C:/strawberry/perl/lib/Time/Local.pm line 85. Use of uninitialized value in pack at C:/strawberry/perl/lib/Time/Local.pm line 69. Use of uninitialized value in pack at C:/strawberry/perl/lib/Time/Local.pm line 69. Use of uninitialized value $_[4] in integer addition (+) at C:/strawberry/perl/lib/Time/Local.pm line 70. Use of uninitialized value $_[5] in integer addition (+) at C:/strawberry/perl/lib/Time/Local.pm line 71. Use of uninitialized value in integer addition (+) at C:/strawberry/perl/lib/Time/Local.pm line 69. Use of uninitialized value $s in integer ne (!=) at C:/strawberry/perl/lib/Time/Local.pm line 178. 1935-01-24T09:08:17 Mon Feb 16 18:16:34 1970 GMT ok 4 Use of uninitialized value in array element at lib/Date/Format.pm line 198. Use of uninitialized value in array element at lib/Date/Format.pm line 200. Use of uninitialized value in sprintf at lib/Date/Format.pm line 207. Use of uninitialized value in sprintf at lib/Date/Format.pm line 208. Use of uninitialized value in sprintf at lib/Date/Format.pm line 215. Use of uninitialized value in sprintf at lib/Date/Format.pm line 222. Use of uninitialized value in addition (+) at lib/Date/Format.pm line 227. Use of uninitialized value $year in integer ge (>=) at C:/strawberry/perl/lib/Time/Local.pm line 94. Use of uninitialized value $year in integer lt (<) at C:/strawberry/perl/lib/Time/Local.pm line 97. Use of uninitialized value $year in integer ge (>=) at C:/strawberry/perl/lib/Time/Local.pm line 97. Use of uninitialized value $year in integer gt (>) at C:/strawberry/perl/lib/Time/Local.pm line 98. Use of uninitialized value $month in integer gt (>) at C:/strawberry/perl/lib/Time/Local.pm line 102. Use of uninitialized value $month in integer lt (<) at C:/strawberry/perl/lib/Time/Local.pm line 102. Use of uninitialized value $month in array element at C:/strawberry/perl/lib/Time/Local.pm line 106. Use of uninitialized value $month in integer eq (==) at C:/strawberry/perl/lib/Time/Local.pm line 107. Use of uninitialized value $mday in integer gt (>) at C:/strawberry/perl/lib/Time/Local.pm line 110. Use of uninitialized value $mday in integer lt (<) at C:/strawberry/perl/lib/Time/Local.pm line 110. Use of uninitialized value $mday in concatenation (.) or string at C:/strawberry/perl/lib/Time/Local.pm line 110. Day '' out of range 1..31 at lib/Date/Format.pm line 230
  Thu Sep 24 09:50:03 2009 kmx [...] cpan.org - Correspondence added
Removing: 1935-01-24T09:08:17 Fri Dec 17 00:00:00 1901 GMT 16 Jun 33 07:29:35 CST from date.t "solves" the issue - but you would probably expect this. -- Karel
  Thu Sep 24 10:14:08 2009 gbarr [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #49963] 1.17 tests fail on Win32/Strawberry perl
Date: Thu, 24 Sep 2009 09:13:45 -0500
To: bug-TimeDate [...] rt.cpan.org
From: Graham Barr <gbarr [...] pobox.com>
OK, So I have made it so those test are skipped on Win32 please try the patch at http://github.com/gbarr/perl-TimeDate/commit/ac438eacaa39389e995b1dda1ccf7957753957bc
  Thu Sep 24 10:53:19 2009 kmx [...] volny.cz - Correspondence added
Subject: Re: [rt.cpan.org #49963] 1.17 tests fail on Win32/Strawberry perl
Date: Thu, 24 Sep 2009 16:52:58 +0200
To: bug-TimeDate [...] rt.cpan.org
From: kmx <kmx [...] volny.cz>
Hi, you should probably add "next" into if like this if ($pre_1970 and $^O eq "MSWin32"){ print "ok ",$loop++," # skip\n"; + next; } -- kmx Graham Barr via RT napsal(a): Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=49963 > > > OK, So I have made it so those test are skipped on Win32 > > please try the patch at > http://github.com/gbarr/perl-TimeDate/commit/ac438eacaa39389e995b1dda1ccf7957753957bc > > > > >
  Thu Sep 24 11:04:29 2009 gbarr [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #49963] 1.17 tests fail on Win32/Strawberry perl
Date: Thu, 24 Sep 2009 10:04:05 -0500
To: bug-TimeDate [...] rt.cpan.org
From: Graham Barr <gbarr [...] pobox.com>
Oops, Thanks. Fixed in this commit http://github.com/gbarr/perl-TimeDate/commit/2c7c5a1421ee3c9b7129ed6df60fd2e7589e1af5
  Thu Sep 24 11:49:15 2009 kmx [...] volny.cz - Correspondence added
CC: kmx [...] cpan.org
Subject: Re: [rt.cpan.org #49963] 1.17 tests fail on Win32/Strawberry perl
Date: Thu, 24 Sep 2009 17:48:52 +0200
To: bug-TimeDate [...] rt.cpan.org
From: kmx <kmx [...] volny.cz>
Show quoted text
> http://github.com/gbarr/perl-TimeDate/commit/2c7c5a1421ee3c9b7129ed6df60fd2e7589e1af5 >
This one works. Looking forward to 1.18 :) Thanks. -- kmx
  Thu Sep 24 18:48:46 2009 GBARR [...] CPAN.ORG - Correspondence added
Fixed in 1.18 just released to CPAN. Allow time for it to reach CPAN mirrors
  Thu Sep 24 18:48:48 2009 GBARR [...] CPAN.ORG - Status changed from 'open' to 'resolved'