Skip Menu |

This queue is for tickets about the Text-FIGlet CPAN distribution.

Report information
The Basics
Id: 49936
Status: resolved
Priority: 0/
Queue: Text-FIGlet

People
Owner: Nobody in particular
Requestors:
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 2.10
Fixed in: (no value)



Subject: No such file or directory: at Text-FIGlet-2.1\blib\lib/Text/FIGlet.pm line 45
This patch will fix some win32 issue, such as fileparse returning .\ Also, PL_FILES isn't neccessary, makemaker will take care of shebang on its own. Thanks
Subject: patch.Text-FIGlet-2.1.txt
diff -ruN Text-FIGlet-2.1/lib/Text/FIGlet/Control.pm Text-FIGlet-2.1-new/lib/Text/FIGlet/Control.pm --- Text-FIGlet-2.1/lib/Text/FIGlet/Control.pm 2009-01-19 10:05:39.000000000 -0800 +++ Text-FIGlet-2.1-new/lib/Text/FIGlet/Control.pm 2009-09-23 01:27:10.328125000 -0700 @@ -26,7 +26,7 @@ foreach my $flc ( @{$self->{-C}} ){ my($file, $path) = fileparse($flc, '\.flc'); - $path = $self->{-d} if $path eq './' && index($flc, './') < 0; + $path = $self->{-d} if $path =~ m!\.[\\/]! && index($flc, './') < 0; open(FLC, File::Spec->catfile($path, $file.'.flc')) || croak("$!: $flc"); while(<FLC>){ diff -ruN Text-FIGlet-2.1/lib/Text/FIGlet/Font.pm Text-FIGlet-2.1-new/lib/Text/FIGlet/Font.pm --- Text-FIGlet-2.1/lib/Text/FIGlet/Font.pm 2009-01-20 22:32:36.000000000 -0800 +++ Text-FIGlet-2.1-new/lib/Text/FIGlet/Font.pm 2009-09-23 01:25:50.000000000 -0700 @@ -26,7 +26,7 @@ #MAGIC minifig0 ($self->{_file}, $path, $ext) = fileparse($self->{-f}, qr/\.[ft]lf/); - $path = $self->{-d} if $path eq './' && index($self->{-f}, './') < 0; + $path = $self->{-d} if $path =~ m!\.[\\/]! && index($self->{-f}, './') < 0; $self->{_file} = File::Spec->catfile($path, $self->{_file}.$ext); $self->{_file} = (glob($self->{_file}.'.?lf'))[0] unless $ext && -e $self->{_file}; diff -ruN Text-FIGlet-2.1/Makefile.PL Text-FIGlet-2.1-new/Makefile.PL --- Text-FIGlet-2.1/Makefile.PL 2009-01-05 10:44:21.000000000 -0800 +++ Text-FIGlet-2.1-new/Makefile.PL 2009-09-23 00:51:41.031250000 -0700 @@ -4,13 +4,14 @@ rename('t', 'TEST') if $] < 5.006; WriteMakefile( - NAME => 'Text::FIGlet', - VERSION_FROM => 'lib/Text/FIGlet.pm', - PL_FILES =>{'minifig.PL'=>'bin/minifig.pl', - 'shebang.PL'=>[qw(bin/charmap.pl - bin/figlet.pl - bin/showfigfonts.pl)] }, - EXE_FILES =>[ glob('bin/*.pl') ], - ($] < 5.006 ? () :#Test dependency bypass - (PREREQ_PM =>{'Test::Differences' => undef})), - ); + NAME => 'Text::FIGlet', + VERSION_FROM => 'lib/Text/FIGlet.pm', + PL_FILES =>{'minifig.PL'=>'bin/minifig.pl', +#~ 'shebang.PL'=>[qw(bin/charmap.pl +#~ bin/figlet.pl +#~ bin/showfigfonts.pl)] + }, + EXE_FILES =>[ glob('bin/*.pl') ], + ($] < 5.006 ? () :#Test dependency bypass + (PREREQ_PM =>{'Test::Differences' => undef})), +);
Show quoted text
>This patch will fix some win32 issue, such as fileparse returning .\
Thanks, but the patch is not general enough. The problem should be resolved in the forthcoming 2.11 though. Show quoted text
>Also, PL_FILES isn't neccessary, makemaker will take care of shebang on
Removed. Note that this module's been around for awhile, and tries to maintain compatibility back to 5.005. It turns out MakeMaker of that era had this behavior (called "fixin"), but it was not well documented.
This should have been normal not critical. You can use UNIX style paths in perl under Windows no-problem; and it's generally a good idea to do so.
Sorry, bloody ancient RT used by CPAN won't let me re-close the ticket without writing something.